Add overloaded WebKitPlatformSupportImpl::createGraphicsContext3D

Add overloaded WebKitPlatformSupportImpl::createGraphicsContext3D

BUG=99516
TEST=None


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=118249

[piman, 2012-01-19 01:52:45]

This is chrome-side of https://bugs.webkit.org/show_bug.cgi?id=76593 .
kbr: please review
tony: OWNERS

[Ken Russell (switch to Gerrit), 2012-01-19 02:05:20]

LGTM as long as it's been tested.

https://chromiumcodereview.appspot.com/9249048/diff/1/webkit/glue/webkitplatf...
File webkit/glue/webkitplatformsupport_impl.h (right):

https://chromiumcodereview.appspot.com/9249048/diff/1/webkit/glue/webkitplatf...
webkit/glue/webkitplatformsupport_impl.h:101: virtual
WebKit::WebGraphicsContext3D* createGraphicsContext3D();
Since your goal is to remove this variant anyway, is there a compelling reason
to add this override now? Note that the base class actually defines this to
return 0.

[piman, 2012-01-19 02:16:37]

I manually tested both chrome and DRT with and without the webkit side.

https://chromiumcodereview.appspot.com/9249048/diff/1/webkit/glue/webkitplatf...
File webkit/glue/webkitplatformsupport_impl.h (right):

https://chromiumcodereview.appspot.com/9249048/diff/1/webkit/glue/webkitplatf...
webkit/glue/webkitplatformsupport_impl.h:101: virtual
WebKit::WebGraphicsContext3D* createGraphicsContext3D();
On 2012/01/19 02:05:20, kbr wrote:
> Since your goal is to remove this variant anyway, is there a compelling reason
> to add this override now? Note that the base class actually defines this to
> return 0.

The reason is that if I just define the 3-params overloaded version, it hides
the 0-params version, so I can't call it except through the explicit
WebKit::WebGraphicsContext3D::createGraphicsContext3D, but that won't call the
derived implementations.

With this I will properly call the derived versions.

[Ken Russell (switch to Gerrit), 2012-01-19 02:23:49]

On 2012/01/19 02:16:37, piman wrote:
> I manually tested both chrome and DRT with and without the webkit side.
> 
>
https://chromiumcodereview.appspot.com/9249048/diff/1/webkit/glue/webkitplatf...
> File webkit/glue/webkitplatformsupport_impl.h (right):
> 
>
https://chromiumcodereview.appspot.com/9249048/diff/1/webkit/glue/webkitplatf...
> webkit/glue/webkitplatformsupport_impl.h:101: virtual
> WebKit::WebGraphicsContext3D* createGraphicsContext3D();
> On 2012/01/19 02:05:20, kbr wrote:
> > Since your goal is to remove this variant anyway, is there a compelling
reason
> > to add this override now? Note that the base class actually defines this to
> > return 0.
> 
> The reason is that if I just define the 3-params overloaded version, it hides
> the 0-params version, so I can't call it except through the explicit
> WebKit::WebGraphicsContext3D::createGraphicsContext3D, but that won't call the
> derived implementations.
> 
> With this I will properly call the derived versions.

I see. Thanks for the clarification. Still LGTM.

[tony, 2012-01-19 02:27:32]

rs LGTM

[commit-bot: I haz the power, 2012-01-19 02:29:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/piman@chromium.org/9249048/1

[commit-bot: I haz the power, 2012-01-19 05:29:08]

Change committed as 118249