Add overloaded WebKitPlatformSupportImpl::createGraphicsContext3D

webkit/glue/webkitplatformsupport_impl.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WEBKIT_PLATFORM_SUPPORT_IMPL_H_
 #define WEBKIT_PLATFORM_SUPPORT_IMPL_H_
 
 #include "base/compiler_specific.h"
 #include "base/platform_file.h"
 #include "base/threading/thread_local_storage.h"
 #include "base/timer.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h"
 #include "webkit/glue/resource_loader_bridge.h"
 #include "webkit/glue/webkit_glue_export.h"
 
 #if defined(OS_WIN)
 #include "webkit/glue/webthemeengine_impl_win.h"
 #elif defined(OS_MACOSX)
 #include "webkit/glue/webthemeengine_impl_mac.h"
 #elif defined(OS_POSIX)
 #include "webkit/glue/webthemeengine_impl_linux.h"
@@ skipping 68 matching lines @@
   virtual double currentTime();
   virtual double monotonicallyIncreasingTime();
   virtual void cryptographicallyRandomValues(
       unsigned char* buffer, size_t length);
   virtual void setSharedTimerFiredFunction(void (*func)());
   virtual void setSharedTimerFireInterval(double interval_seconds);
   virtual void stopSharedTimer();
   virtual void callOnMainThread(void (*func)(void*), void* context);
   virtual WebKit::WebThread* createThread(const char* name);
   virtual WebKit::WebThread* currentThread();
+  virtual WebKit::WebGraphicsContext3D* createGraphicsContext3D();

[Ken Russell (switch to Gerrit), 2012/01/19 02:05:20]

Since your goal is to remove this variant anyway, is there a compelling reason
to add this override now? Note that the base class actually defines this to
return 0.

[piman, 2012/01/19 02:16:37]

The reason is that if I just define the 3-params overloaded version, it hides
the 0-params version, so I can't call it except through the explicit
WebKit::WebGraphicsContext3D::createGraphicsContext3D, but that won't call the
derived implementations.

With this I will properly call the derived versions.

+  virtual WebKit::WebGraphicsContext3D* createGraphicsContext3D(
+      WebKit::WebGraphicsContext3D::Attributes attributes,
+      WebKit::WebView* web_view,
+      bool render_to_web_view);
 
 
   // Embedder functions. The following are not implemented by the glue layer and
   // need to be specialized by the embedder.
 
   // Gets a localized string given a message id.  Returns an empty string if the
   // message id is not found.
   virtual string16 GetLocalizedString(int message_id) = 0;
 
   // Returns the raw data for a resource.  This resource must have been
@@ skipping 31 matching lines @@
   void (*shared_timer_func_)();
   double shared_timer_fire_time_;
   int shared_timer_suspended_;  // counter
   WebThemeEngineImpl theme_engine_;
   base::ThreadLocalStorage::Slot current_thread_slot_;
 };
 
 }  // namespace webkit_glue
 
 #endif  // WEBKIT_PLATFORM_SUPPORT_IMPL_H_