Add overloaded WebKitPlatformSupportImpl::createGraphicsContext3D

webkit/glue/webkitplatformsupport_impl.h

Index: webkit/glue/webkitplatformsupport_impl.h
diff --git a/webkit/glue/webkitplatformsupport_impl.h b/webkit/glue/webkitplatformsupport_impl.h
index 02a7266933f3b10a801aeea3cc8b412ec154cd9f..e6cb6c9ba5afcf033753a6922ea9c04b7b59fe8e 100644
--- a/webkit/glue/webkitplatformsupport_impl.h
+++ b/webkit/glue/webkitplatformsupport_impl.h
@@ -9,6 +9,7 @@
 #include "base/platform_file.h"
 #include "base/threading/thread_local_storage.h"
 #include "base/timer.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebGraphicsContext3D.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h"
 #include "webkit/glue/resource_loader_bridge.h"
 #include "webkit/glue/webkit_glue_export.h"
@@ -97,6 +98,11 @@ class WEBKIT_GLUE_EXPORT WebKitPlatformSupportImpl :
   virtual void callOnMainThread(void (*func)(void*), void* context);
   virtual WebKit::WebThread* createThread(const char* name);
   virtual WebKit::WebThread* currentThread();
+  virtual WebKit::WebGraphicsContext3D* createGraphicsContext3D();

[Ken Russell (switch to Gerrit), 2012/01/19 02:05:20]

Since your goal is to remove this variant anyway, is there a compelling reason
to add this override now? Note that the base class actually defines this to
return 0.

[piman, 2012/01/19 02:16:37]

The reason is that if I just define the 3-params overloaded version, it hides
the 0-params version, so I can't call it except through the explicit
WebKit::WebGraphicsContext3D::createGraphicsContext3D, but that won't call the
derived implementations.

With this I will properly call the derived versions.

+  virtual WebKit::WebGraphicsContext3D* createGraphicsContext3D(
+      WebKit::WebGraphicsContext3D::Attributes attributes,
+      WebKit::WebView* web_view,
+      bool render_to_web_view);
 
 
   // Embedder functions. The following are not implemented by the glue layer and