Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Unified Diff: dart/frog/leg/scanner/class_element_parser.dart

Issue 9241014: Generate AST nodes for field initializers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/resolver.dart ('k') | dart/frog/leg/scanner/listener.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/scanner/class_element_parser.dart
diff --git a/dart/frog/leg/scanner/class_element_parser.dart b/dart/frog/leg/scanner/class_element_parser.dart
index 0f75827b6fc957d924ab6f4eeb9cae3030ca88f7..9cb27f9a59d2b9aa979ef6afba01a510f1562f5a 100644
--- a/dart/frog/leg/scanner/class_element_parser.dart
+++ b/dart/frog/leg/scanner/class_element_parser.dart
@@ -48,7 +48,11 @@ class MemberListener extends NodeListener {
super.endMethod(beginToken, endToken);
FunctionExpression method = popNode();
pushNode(null);
- Identifier name = method.name; // TODO(ahe): Named constructors.
+ Expression qualified = method.name;
+ Identifier name = qualified.asIdentifier();
+ if (name === null) {
+ canceler.cancel('qualified names are not implemented', node: qualified);
+ }
ElementKind kind = isConstructor(name) ?
ElementKind.GENERATIVE_CONSTRUCTOR :
ElementKind.FUNCTION;
@@ -80,9 +84,9 @@ class MemberListener extends NodeListener {
VariableDefinitions variableDefinitions = popNode();
Modifiers modifiers = variableDefinitions.modifiers;
pushNode(null);
- void buildFieldElement(SourceString name, Node node, Element fields) {
+ void buildFieldElement(SourceString name, Element fields) {
Element element = new VariableElement(
- name, node, fields, ElementKind.FIELD, enclosingElement);
+ name, fields, ElementKind.FIELD, enclosingElement);
enclosingElement.addMember(element);
}
buildFieldElements(modifiers, variableDefinitions.definitions,
@@ -90,9 +94,6 @@ class MemberListener extends NodeListener {
}
void endInitializer(Token assignmentOperator) {
- // TODO(floitsch): Remove this cancel.
- canceler.cancel("field initializers are not implemented",
- token: assignmentOperator);
pushNode(null); // Super expects an expression, but
// ClassElementParser just skips expressions.
super.endInitializer(assignmentOperator);
« no previous file with comments | « dart/frog/leg/resolver.dart ('k') | dart/frog/leg/scanner/listener.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698