Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Unified Diff: dart/frog/leg/resolver.dart

Issue 9241014: Generate AST nodes for field initializers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/elements/elements.dart ('k') | dart/frog/leg/scanner/class_element_parser.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/resolver.dart
diff --git a/dart/frog/leg/resolver.dart b/dart/frog/leg/resolver.dart
index a46f4a2aa43c3e43ee5f83aeb670e8845baf871a..fa6e2108d39c5c9e333e46dfc27e65b033c981db 100644
--- a/dart/frog/leg/resolver.dart
+++ b/dart/frog/leg/resolver.dart
@@ -215,7 +215,11 @@ class ResolverVisitor extends AbstractVisitor/*<Element>*/ {
}
visitTypeAnnotation(TypeAnnotation node) {
- Identifier name = node.typeName;
+ Identifier name = node.typeName.asIdentifier();
+ if (name === null) {
+ // TODO(karlklose): In progress.
+ cancel(node.typeName, "not implemented");
+ }
if (name.source == const SourceString('var')) return null;
if (name.source == const SourceString('void')) return null;
Element element = context.lookup(name.source);
@@ -330,6 +334,12 @@ class FullResolverVisitor extends ResolverVisitor {
visitFunctionExpression(FunctionExpression node) {
visit(node.returnType);
+ if (node.name === null) {
+ cancel(node, "anonymous functions are not implemented");
+ }
+ if (node.name.asIdentifier() === null) {
+ cancel(node.name, "named constructors are not implemented");
+ }
FunctionElement enclosingElement = new FunctionElement.node(
node, ElementKind.FUNCTION, null, context.element);
defineElement(node, enclosingElement);
@@ -707,8 +717,9 @@ class VariableDefinitionsVisitor extends AbstractVisitor/*<SourceString>*/ {
visitNodeList(NodeList node) {
for (Link<Node> link = node.nodes; !link.isEmpty(); link = link.tail) {
SourceString name = visit(link.head);
- Element element = new VariableElement(
- name, node, variables, kind, resolver.context.element);
+ VariableElement element = new VariableElement(
+ name, variables, kind, resolver.context.element);
+ element.node = link.head;
resolver.defineElement(link.head, element);
}
}
« no previous file with comments | « dart/frog/leg/elements/elements.dart ('k') | dart/frog/leg/scanner/class_element_parser.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698