Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Unified Diff: dart/frog/leg/scanner/listener.dart

Issue 9241014: Generate AST nodes for field initializers. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: changes Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « dart/frog/leg/scanner/class_element_parser.dart ('k') | dart/frog/leg/scanner/scanner_task.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart/frog/leg/scanner/listener.dart
diff --git a/dart/frog/leg/scanner/listener.dart b/dart/frog/leg/scanner/listener.dart
index 8cac80128c73a6ed1552dd3c35493f2d32c41776..02d631076812265e29d36894352a8bf5d16107e1 100644
--- a/dart/frog/leg/scanner/listener.dart
+++ b/dart/frog/leg/scanner/listener.dart
@@ -509,9 +509,9 @@ class ElementListener extends Listener {
}
void endTopLevelFields(int count, Token beginToken, Token endToken) {
- void buildFieldElement(SourceString name, Node node, Element fields) {
+ void buildFieldElement(SourceString name, Element fields) {
pushElement(new VariableElement(
- name, node, fields, ElementKind.FIELD, compilationUnitElement));
+ name, fields, ElementKind.FIELD, compilationUnitElement));
}
NodeList variables = makeNodeList(count, null, null, ",");
Modifiers modifiers = popNode();
@@ -522,7 +522,6 @@ class ElementListener extends Listener {
void buildFieldElements(Modifiers modifiers,
NodeList variables,
void buildFieldElement(SourceString name,
- Node node,
Element fields),
Token beginToken, Token endToken) {
Element fields = new PartialFieldListElement(beginToken,
@@ -537,16 +536,10 @@ class ElementListener extends Listener {
identifier = initializedIdentifier.asSendSet().selector.asIdentifier();
}
SourceString name = identifier.source;
- buildFieldElement(name, initializedIdentifier, fields);
+ buildFieldElement(name, fields);
}
}
- void endInitializer(Token assignmentOperator) {
- // TODO(floitsch): Remove this method.
- canceler.cancel("field initializers are not implemented",
- token: assignmentOperator);
- }
-
void handleIdentifier(Token token) {
pushNode(new Identifier(token));
}
@@ -1253,7 +1246,7 @@ class PartialFieldListElement extends VariableListElement {
Element enclosing)
: super(ElementKind.VARIABLE_LIST, modifiers, enclosing);
- Node parseNode(Canceler canceler, Logger logger) {
+ VariableDefinitions parseNode(Canceler canceler, Logger logger) {
if (node != null) return node;
node = parse(canceler, logger,
(p) => p.parseVariablesDeclaration(beginToken));
« no previous file with comments | « dart/frog/leg/scanner/class_element_parser.dart ('k') | dart/frog/leg/scanner/scanner_task.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698