Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(528)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9234076: Implementation of the Extension Activity Log UI behind a flag. (Closed)

Created:
8 years, 11 months ago by Eric Dingle
Modified:
8 years, 10 months ago
CC:
chromium-reviews, Aaron Boodman, arv (Not doing code reviews), mihaip+watch_chromium.org, Ben Goodger (Google)
Visibility:
Public.

Description

Implementation of the Extension Activity Log UI behind a flag. BUG=39802 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=120146

Patch Set 1 #

Total comments: 25

Patch Set 2 : Address Dan's comments. #

Total comments: 4

Patch Set 3 : Address remaining comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+321 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 2 3 chunks +20 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/browser_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download
A chrome/browser/resources/extensions/extension_activity.css View 1 1 chunk +16 lines, -0 lines 0 comments Download
A chrome/browser/resources/extensions/extension_activity.html View 1 1 chunk +53 lines, -0 lines 0 comments Download
A chrome/browser/resources/extensions/extension_activity.js View 1 1 chunk +50 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions/extension_list.js View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/resources/extensions/extensions.html View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/resources/options/extension_list.js View 1 chunk +9 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/chrome_web_ui_controller_factory.cc View 1 2 chunks +7 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/extensions/extension_activity_ui.h View 1 2 1 chunk +32 lines, -0 lines 0 comments Download
A chrome/browser/ui/webui/extensions/extension_activity_ui.cc View 1 1 chunk +101 lines, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/extension_settings_handler.cc View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/url_constants.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/common/url_constants.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Eric Dingle
8 years, 11 months ago (2012-01-26 23:35:08 UTC) #1
Dan Beam
There seems to have been a bit of talk lately about not implementing more features ...
8 years, 11 months ago (2012-01-26 23:45:39 UTC) #2
Ben Goodger (Google)
What is the context that this feature shows up in? Can someone send me a ...
8 years, 11 months ago (2012-01-26 23:52:31 UTC) #3
Dan Beam
https://chromiumcodereview.appspot.com/9234076/diff/1/chrome/browser/resources/extensions/extension_activity.css File chrome/browser/resources/extensions/extension_activity.css (right): https://chromiumcodereview.appspot.com/9234076/diff/1/chrome/browser/resources/extensions/extension_activity.css#newcode3 chrome/browser/resources/extensions/extension_activity.css:3: * found in the LICENSE file. nit: * found ...
8 years, 11 months ago (2012-01-28 04:24:41 UTC) #4
Eric Dingle
http://codereview.chromium.org/9234076/diff/1/chrome/browser/resources/extensions/extension_activity.css File chrome/browser/resources/extensions/extension_activity.css (right): http://codereview.chromium.org/9234076/diff/1/chrome/browser/resources/extensions/extension_activity.css#newcode3 chrome/browser/resources/extensions/extension_activity.css:3: * found in the LICENSE file. On 2012/01/28 04:24:41, ...
8 years, 10 months ago (2012-01-30 18:27:11 UTC) #5
Dan Beam (Google)
lgtm w/nits, you probably want to wait for estade's review as well (I also don't ...
8 years, 10 months ago (2012-01-30 19:26:51 UTC) #6
Evan Stade
lgtm https://chromiumcodereview.appspot.com/9234076/diff/9001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://chromiumcodereview.appspot.com/9234076/diff/9001/chrome/app/generated_resources.grd#newcode4376 chrome/app/generated_resources.grd:4376: API Block this doesn't seem like the best ...
8 years, 10 months ago (2012-01-31 03:52:36 UTC) #7
Eric Dingle
Thanks, guys! Submitting. http://codereview.chromium.org/9234076/diff/9001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): http://codereview.chromium.org/9234076/diff/9001/chrome/app/generated_resources.grd#newcode4376 chrome/app/generated_resources.grd:4376: API Block On 2012/01/31 03:52:36, Evan ...
8 years, 10 months ago (2012-02-02 00:36:48 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ericdingle@chromium.org/9234076/16001
8 years, 10 months ago (2012-02-02 00:38:58 UTC) #9
commit-bot: I haz the power
8 years, 10 months ago (2012-02-02 01:58:12 UTC) #10 
Change committed as 120146

Powered by Google App Engine
This is Rietveld 408576698