chrome/browser/resources/extensions/extension_activity.html - Issue 9234076: Implementation of the Extension Activity Log UI behind a flag.

Side by Side Diff: chrome/browser/resources/extensions/extension_activity.html

Issue 9234076: Implementation of the Extension Activity Log UI behind a flag. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/extensions/extension_activity.css ('K') | « chrome/browser/resources/extensions/extension_activity.css ('k') | chrome/browser/resources/extensions/extension_activity.js » ('j') | chrome/browser/resources/extensions/extension_activity.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>
	Dan Beam 2012/01/28 04:24:41 copyright copyright Eric Dingle 2012/01/30 18:27:11 None of the other HTML files have a copyright mess Show quoted text On 2012/01/28 04:24:41, Dan Beam wrote: > copyright None of the other HTML files have a copyright message, so I'm not sure what to put here. Suggestions? Dan Beam (Google) 2012/01/30 19:26:51 Ah, I guess a lot of them don't, hmmm. I'll talk Show quoted text On 2012/01/30 18:27:11, Eric Dingle wrote: > On 2012/01/28 04:24:41, Dan Beam wrote: > > copyright > > None of the other HTML files have a copyright message, so I'm not sure what to > put here. Suggestions? Ah, I guess a lot of them don't, hmmm. I'll talk to some other OWNERs of WebUI as some files do have this (http://src.chromium.org/viewvc/chrome/trunk/src/chrome/browser/resources/sync..., for instance) and it seems like every .html file should have this kind of notice at the top (I don't really see how HTML files should be exempted from copyright notices).
	2 <html i18n-values="dir:textdirection;">

	3 <head>

	4 <meta charset="utf-8">

	5

	6 <link rel="stylesheet" href="extensions.css">

	7 <link rel="stylesheet" href="extension_activity.css">

	8 <link rel="stylesheet" href="../shared/css/chrome_shared2.css">

	9

	10 <script src="chrome://resources/js/cr.js"></script>

	11 <script src="chrome://resources/js/i18n_template.js"></script>

	12 <script src="chrome://resources/js/util.js"></script>

	13

	14 <script src="chrome://extension-activity/strings.js"></script>

	15 <script src="chrome://extension-activity/extension_activity.js"></script>

	16

	17 </head>

	18

	19 <body>

	20

	21 <div id="extension-activity">

	22 <h1 i18n-content="extensionActivity"></h1>

	23 <div class="extension-list-item">

	24 <div class="extension-details">

	25 <div>

	26 <span class="extension-title"></span>

	27 <span class="extension-version"></span>

	28 </div>

	29 <p class="extension-description"></p>

	30 </div>

	31 </div>

	32 <div id="extension-activity-list"></div>

	33 </div>

	34

	35 <div id="template-collection" hidden>

	36
	Dan Beam 2012/01/28 04:24:41 nit: no extra newlines inside #template-collection nit: no extra newlines inside #template-collection Eric Dingle 2012/01/30 18:27:11 Done. Show quoted text On 2012/01/28 04:24:41, Dan Beam wrote: > nit: no extra newlines inside #template-collection Done.
	37 <div class="extension-activity-labels">

	38 <!-- The indices here match the activity enum defined in

	39 chrome/browser/extensions/extension_activity_log.h -->

	40 <span class="extension-activity-label-0"

	41 i18n-content="extensionActivityApiCall"></span>

	42 <span class="extension-activity-label-1"

	43 i18n-content="extensionActivityApiBlock"></span>

	44 </div>

	45

	46 <div class="extension-activity-item">

	47 <span class="extension-activity-time"></span>

	48 <span class="extension-activity-label"></span>

	49 <span class="extension-activity-message"></span>

	50 </div>

	51

	52 </div>

	53

	54 </body>

	55 </html>

OLD	NEW