Fix several clang warnings in breakpad.

Fix several clang warnings in breakpad.

uploader.mm:549:5: warning: instance method '-uploadData:name:url:' not found (return type defaults to 'id')
    [self uploadData:logFileData_ name:@"log" url:url];
=> it looks like this method does in fact not exist, the last parameter
   needs to be removed.

breakpad_nlist_64.cc:193:59: warning: '&&' within '||' [-Wlogical-op-parentheses]
=> Just add parentheses, no functionality change.

Patch by Nico Weber <thakis@chromium.org>;

BUG=none
TEST=breakpad stil works.

Breakpad r907

[Mark Mentovai, 2012-01-26 14:27:39]

https://chromiumcodereview.appspot.com/9234054/diff/2001/common/mac/MachIPC.mm
File common/mac/MachIPC.mm (right):

https://chromiumcodereview.appspot.com/9234054/diff/2001/common/mac/MachIPC.m...
common/mac/MachIPC.mm:191: [[NSMachBootstrapServer sharedInstance]
registerPort:ns_port name:port_name];
Rather than doing this Cocoa stuff, bpoop uses the old API wrapped in something
to suppress the warnings:

// Wraps bootstrap_register to avoid the deprecation warning. It needs to be
// used on 10.5.
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
static kern_return_t BootstrapRegister(mach_port_t bp,
                                       name_t service_name,
                                       mach_port_t sp) {
  return bootstrap_register(bp, service_name, sp);
}
#pragma GCC diagnostic warning "-Wdeprecated-declarations"

I prefer that to the higher-level Cocoa stuff with all of its newfangled
shared-instance objects and autorelease pools.

[Nico, 2012-01-26 18:07:39]

https://chromiumcodereview.appspot.com/9234054/diff/2001/common/mac/MachIPC.mm
File common/mac/MachIPC.mm (right):

https://chromiumcodereview.appspot.com/9234054/diff/2001/common/mac/MachIPC.m...
common/mac/MachIPC.mm:191: [[NSMachBootstrapServer sharedInstance]
registerPort:ns_port name:port_name];
If breakpad doesn't care about -Wdeprecated-declarations, I'll just add
-Wno-deprecated-declarations to the gyp file. Reverted the changes to this file.

[Mark Mentovai, 2012-01-26 18:13:07]

bpoop will still care about deprecated declarations, but that’ll involve a
rework of the .gyp anyway, so that’s fine. LGTM.

[Nico, 2012-01-26 18:21:02]

Thanks! Can you land this for me?

[Mark Mentovai, 2012-01-26 19:06:00]

Landed Breakpad r907 after fixing the commit message.