Fix several clang warnings in breakpad.

common/mac/MachIPC.mm

 // Copyright (c) 2007, Google Inc.
 // All rights reserved.
 //
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 // notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
@@ skipping 163 matching lines @@
     return;
     
   init_result_ = mach_port_insert_right(current_task,
                                         port_,
                                         port_,
                                         MACH_MSG_TYPE_MAKE_SEND);
 
   if (init_result_ != KERN_SUCCESS)
     return;
 
-  mach_port_t task_bootstrap_port = 0;
-  init_result_ = task_get_bootstrap_port(current_task, &task_bootstrap_port);
-
-  if (init_result_ != KERN_SUCCESS)
-    return;
-
-  init_result_ = bootstrap_register(bootstrap_port,
-                                    const_cast<char*>(receive_port_name),
-                                    port_);
+  // Without |NSMachPortDeallocateNone|, the NSMachPort seems to deallocate
+  // receive rights on port when it is eventually released.  It is not necessary
+  // to deallocate any rights here as |port_| is fully deallocated in the
+  // ReceivePort destructor.
+  NSPort *ns_port = [NSMachPort portWithMachPort:port_
+                                         options:NSMachPortDeallocateNone];
+  NSString *port_name = [NSString stringWithUTF8String:receive_port_name];
+  [[NSMachBootstrapServer sharedInstance] registerPort:ns_port name:port_name];

[Mark Mentovai, 2012/01/26 14:27:40]

Rather than doing this Cocoa stuff, bpoop uses the old API wrapped in something
to suppress the warnings:

// Wraps bootstrap_register to avoid the deprecation warning. It needs to be
// used on 10.5.
#pragma GCC diagnostic ignored "-Wdeprecated-declarations"
static kern_return_t BootstrapRegister(mach_port_t bp,
                                       name_t service_name,
                                       mach_port_t sp) {
  return bootstrap_register(bp, service_name, sp);
}
#pragma GCC diagnostic warning "-Wdeprecated-declarations"

I prefer that to the higher-level Cocoa stuff with all of its newfangled
shared-instance objects and autorelease pools.

[Nico, 2012/01/26 18:07:39]

If breakpad doesn't care about -Wdeprecated-declarations, I'll just add
-Wno-deprecated-declarations to the gyp file. Reverted the changes to this file.

 }
 
 //==============================================================================
 // create a new mach port for receiving messages
 ReceivePort::ReceivePort() {
   mach_port_t current_task = mach_task_self();
 
   init_result_ = mach_port_allocate(current_task,
                                     MACH_PORT_RIGHT_RECEIVE,
                                     &port_);
@@ skipping 92 matching lines @@
                                   message.head.msgh_size,
                                   0,
                                   MACH_PORT_NULL,
                                   timeout,              // timeout in ms
                                   MACH_PORT_NULL);
 
   return result;
 }
 
 }  // namespace google_breakpad