Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Side by Side Diff: client/mac/sender/uploader.mm

Issue 9234054: Fix several clang warnings in breakpad. (Closed) Base URL: http://google-breakpad.googlecode.com/svn/trunk/src/
Patch Set: . Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « client/mac/handler/breakpad_nlist_64.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, Google Inc. 1 // Copyright (c) 2011, Google Inc.
2 // All rights reserved. 2 // All rights reserved.
3 // 3 //
4 // Redistribution and use in source and binary forms, with or without 4 // Redistribution and use in source and binary forms, with or without
5 // modification, are permitted provided that the following conditions are 5 // modification, are permitted provided that the following conditions are
6 // met: 6 // met:
7 // 7 //
8 // * Redistributions of source code must retain the above copyright 8 // * Redistributions of source code must retain the above copyright
9 // notice, this list of conditions and the following disclaimer. 9 // notice, this list of conditions and the following disclaimer.
10 // * Redistributions in binary form must reproduce the above 10 // * Redistributions in binary form must reproduce the above
(...skipping 528 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 } 539 }
540 else { 540 else {
541 // can't rename - don't worry - it's not important for users 541 // can't rename - don't worry - it's not important for users
542 GTMLoggerDebug(@"Breakpad Uploader: successful upload report ID = %s\n", 542 GTMLoggerDebug(@"Breakpad Uploader: successful upload report ID = %s\n",
543 reportID ); 543 reportID );
544 } 544 }
545 [result release]; 545 [result release];
546 } 546 }
547 547
548 if (logFileData_) { 548 if (logFileData_) {
549 [self uploadData:logFileData_ name:@"log" url:url]; 549 [self uploadData:logFileData_ name:@"log"];
550 } 550 }
551 551
552 [upload release]; 552 [upload release];
553 } 553 }
554 554
555 - (void)uploadData:(NSData *)data name:(NSString *)name { 555 - (void)uploadData:(NSData *)data name:(NSString *)name {
556 NSURL *url = [NSURL URLWithString:[parameters_ objectForKey:@BREAKPAD_URL]]; 556 NSURL *url = [NSURL URLWithString:[parameters_ objectForKey:@BREAKPAD_URL]];
557 NSMutableDictionary *uploadParameters = [NSMutableDictionary dictionary]; 557 NSMutableDictionary *uploadParameters = [NSMutableDictionary dictionary];
558 558
559 if (![self populateServerDictionary:uploadParameters]) 559 if (![self populateServerDictionary:uploadParameters])
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
604 [minidumpContents_ release]; 604 [minidumpContents_ release];
605 [logFileData_ release]; 605 [logFileData_ release];
606 [googleDictionary_ release]; 606 [googleDictionary_ release];
607 [socorroDictionary_ release]; 607 [socorroDictionary_ release];
608 [serverDictionary_ release]; 608 [serverDictionary_ release];
609 [extraServerVars_ release]; 609 [extraServerVars_ release];
610 [super dealloc]; 610 [super dealloc];
611 } 611 }
612 612
613 @end 613 @end
OLDNEW
« no previous file with comments | « client/mac/handler/breakpad_nlist_64.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698