Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9178024: Disable harmless warnings for 3rdparty code: ICU. (Closed)

Created:
8 years, 11 months ago by Nico
Modified:
8 years, 11 months ago
Reviewers:
Evan Martin
CC:
chromium-reviews, jungshik at Google
Visibility:
Public.

Description

Disable harmless warnings for 3rdparty code: ICU. BUG=102390 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=117933

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -2 lines) Patch
M icu.gyp View 1 4 chunks +41 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nico
8 years, 11 months ago (2012-01-17 19:10:12 UTC) #1
Evan Martin
LGTM
8 years, 11 months ago (2012-01-17 19:12:41 UTC) #2
Evan Martin
https://chromiumcodereview.appspot.com/9178024/diff/1/icu.gyp File icu.gyp (right): https://chromiumcodereview.appspot.com/9178024/diff/1/icu.gyp#newcode334 icu.gyp:334: '-Wno-header-hygiene', This one makes me sad. It's spotting a ...
8 years, 11 months ago (2012-01-17 19:12:54 UTC) #3
Nico
8 years, 11 months ago (2012-01-17 19:17:15 UTC) #4 
On 2012/01/17 19:12:54, Evan Martin wrote:
> https://chromiumcodereview.appspot.com/9178024/diff/1/icu.gyp
> File icu.gyp (right):
> 
> https://chromiumcodereview.appspot.com/9178024/diff/1/icu.gyp#newcode334
> icu.gyp:334: '-Wno-header-hygiene',
> This one makes me sad.  It's spotting a real bug.

I filed http://bugs.icu-project.org/trac/ticket/9054 and added that to the
comment.

Powered by Google App Engine
This is Rietveld 408576698