Disable harmless warnings for 3rdparty code: ICU.

icu.gyp

 # Copyright (c) 2011 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'variables': {
     'use_system_icu%': 0,
     'icu_use_data_file_flag%': 0,
   },
   'target_defaults': {
@@ skipping 265 matching lines @@
               'cflags': [
                 '-Wno-deprecated-declarations',
               ],
               'cflags_cc': [
                 '-frtti',
               ],
             }],
             ['OS == "mac"', {
               'xcode_settings': {
                 'GCC_ENABLE_CPP_RTTI': 'YES',       # -frtti
-              }
+              },
             }],
             ['OS == "win"', {
               'msvs_settings': {
                 'VCCLCompilerTool': {
                   'RuntimeTypeInfo': 'true',
                 },
               }
             }],
             ['OS == "android"', {
               'include_dirs': [
@@ skipping 16 matching lines @@
                 }],
                 ['target_arch=="ia32"', {
                   'link_settings': {
                     'libraries': [
                       '<(android_ndk_root)/sources/cxx-stl/gabi++/libs/x86/libgabi++_static.a',
                     ]
                   },
                 }],
               ],
             }],
+            ['clang==1', {
+              'xcode_settings': {
+                'WARNING_CFLAGS': [
+                  # ICU uses its own deprecated functions.
+                  '-Wno-deprecated-declarations',
+                  # ICU prefers `a && b || c` over `(a && b) || c`.
+                  '-Wno-logical-op-parentheses',
+                  # ICU has some `unsigned < 0` checks.
+                  '-Wno-tautological-compare',
+                  # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
+                  # the header should use U_NAMESPACE_BEGIN instead.
+                  '-Wno-header-hygiene',

[Evan Martin, 2012/01/17 19:12:54]

This one makes me sad.  It's spotting a real bug.

+                ],
+              },
+              'cflags': [
+                '-Wno-deprecated-declarations',
+                '-Wno-logical-op-parentheses',
+                '-Wno-tautological-compare',
+                '-Wno-header-hygiene',
+              ],
+            }],
           ],
         },
         {
           'target_name': 'icuuc',
           'type': '<(component)',
           'sources': [
             'source/common/bmpset.cpp',
             'source/common/brkeng.cpp',
             'source/common/brkiter.cpp',
             'source/common/bytestream.cpp',
@@ skipping 184 matching lines @@
                 '-Wno-deprecated-declarations',
                 '-Wno-unused-function',
               ],
               'cflags_cc': [
                 '-frtti',
               ],
             }],
             ['OS == "mac"', {
               'xcode_settings': {
                 'GCC_ENABLE_CPP_RTTI': 'YES',       # -frtti
-              }
+              },
             }],
             ['OS == "win"', {
               'msvs_settings': {
                 'VCCLCompilerTool': {
                   'RuntimeTypeInfo': 'true',
                 },
               }
             }],
             ['OS == "android"', {
               'include_dirs': [
@@ skipping 16 matching lines @@
                 }],
                 ['target_arch=="ia32"', {
                   'link_settings': {
                     'libraries': [
                       '<(android_ndk_root)/sources/cxx-stl/gabi++/libs/x86/libgabi++_static.a',
                     ]
                   },
                 }],
               ],
             }],
+            ['clang==1', {
+              'xcode_settings': {
+                'WARNING_CFLAGS': [
+                  # ICU uses its own deprecated functions.
+                  '-Wno-deprecated-declarations',
+                  # ICU prefers `a && b || c` over `(a && b) || c`.
+                  '-Wno-logical-op-parentheses',
+                  # ICU has some `unsigned < 0` checks.
+                  '-Wno-tautological-compare',
+                ],
+              },
+              'cflags': [
+                '-Wno-deprecated-declarations',
+                '-Wno-logical-op-parentheses',
+                '-Wno-tautological-compare',
+              ],
+            }],
           ],
         },
       ],
     }, { # use_system_icu != 0
       'targets': [
         {
           'target_name': 'system_icu',
           'type': 'settings',
           'direct_dependent_settings': {
             'defines': [
@@ skipping 24 matching lines @@
         {
           'target_name': 'icuuc',
           'type': 'none',
           'dependencies': ['system_icu'],
           'export_dependent_settings': ['system_icu'],
         },
       ],
     }],
   ],
 }