Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: icu.gyp

Issue 9178024: Disable harmless warnings for 3rdparty code: ICU. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/icu46/
Patch Set: '' Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: icu.gyp
===================================================================
--- icu.gyp (revision 113543)
+++ icu.gyp (working copy)
@@ -283,7 +283,7 @@
['OS == "mac"', {
'xcode_settings': {
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
- }
+ },
}],
['OS == "win"', {
'msvs_settings': {
@@ -320,6 +320,28 @@
}],
],
}],
+ ['clang==1', {
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': [
+ # ICU uses its own deprecated functions.
+ '-Wno-deprecated-declarations',
+ # ICU prefers `a && b || c` over `(a && b) || c`.
+ '-Wno-logical-op-parentheses',
+ # ICU has some `unsigned < 0` checks.
+ '-Wno-tautological-compare',
+ # uspoof.h has a U_NAMESPACE_USE macro. That's a bug,
+ # the header should use U_NAMESPACE_BEGIN instead.
+ # http://bugs.icu-project.org/trac/ticket/9054
+ '-Wno-header-hygiene',
+ ],
+ },
+ 'cflags': [
+ '-Wno-deprecated-declarations',
+ '-Wno-logical-op-parentheses',
+ '-Wno-tautological-compare',
+ '-Wno-header-hygiene',
+ ],
+ }],
],
},
{
@@ -524,7 +546,7 @@
['OS == "mac"', {
'xcode_settings': {
'GCC_ENABLE_CPP_RTTI': 'YES', # -frtti
- }
+ },
}],
['OS == "win"', {
'msvs_settings': {
@@ -561,6 +583,23 @@
}],
],
}],
+ ['clang==1', {
+ 'xcode_settings': {
+ 'WARNING_CFLAGS': [
+ # ICU uses its own deprecated functions.
+ '-Wno-deprecated-declarations',
+ # ICU prefers `a && b || c` over `(a && b) || c`.
+ '-Wno-logical-op-parentheses',
+ # ICU has some `unsigned < 0` checks.
+ '-Wno-tautological-compare',
+ ],
+ },
+ 'cflags': [
+ '-Wno-deprecated-declarations',
+ '-Wno-logical-op-parentheses',
+ '-Wno-tautological-compare',
+ ],
+ }],
],
},
],
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698