chrome/browser/content_settings/content_settings_observable_provider.h - Issue 9159053: Coverity: pass ContentSettingsPattern by const ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_observable_provider.h

Issue 9159053: Coverity: pass ContentSettingsPattern by const ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix MockObserver Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_mock_observer.h ('k') | chrome/browser/content_settings/content_settings_observable_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_observable_provider.h

diff --git a/chrome/browser/content_settings/content_settings_observable_provider.h b/chrome/browser/content_settings/content_settings_observable_provider.h

index 28d8ecdd4c23698d69dfe16c7310bd8508f0f0eb..4cb3558ab33c90abb1d0c9e82f80b43ae26d214a 100644

--- a/chrome/browser/content_settings/content_settings_observable_provider.h

+++ b/chrome/browser/content_settings/content_settings_observable_provider.h

@@ -23,8 +23,8 @@ class ObservableProvider : public ProviderInterface {

void RemoveObserver(Observer* observer);

protected:

- void NotifyObservers(ContentSettingsPattern primary_pattern,

- ContentSettingsPattern secondary_pattern,

+ void NotifyObservers(const ContentSettingsPattern& primary_pattern,

+ const ContentSettingsPattern& secondary_pattern,

ContentSettingsType content_type,

std::string resource_identifier);

void RemoveAllObservers();