Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: chrome/browser/content_settings/content_settings_observable_provider.h

Issue 9159053: Coverity: pass ContentSettingsPattern by const ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix MockObserver Created 8 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_OBSERVABLE_PROVIDER_H_ 5 #ifndef CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_OBSERVABLE_PROVIDER_H_
6 #define CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_OBSERVABLE_PROVIDER_H_ 6 #define CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_OBSERVABLE_PROVIDER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/observer_list.h" 10 #include "base/observer_list.h"
11 #include "chrome/browser/content_settings/content_settings_provider.h" 11 #include "chrome/browser/content_settings/content_settings_provider.h"
12 #include "chrome/browser/content_settings/content_settings_observer.h" 12 #include "chrome/browser/content_settings/content_settings_observer.h"
13 #include "chrome/common/content_settings_pattern.h" 13 #include "chrome/common/content_settings_pattern.h"
14 14
15 namespace content_settings { 15 namespace content_settings {
16 16
17 class ObservableProvider : public ProviderInterface { 17 class ObservableProvider : public ProviderInterface {
18 public: 18 public:
19 ObservableProvider(); 19 ObservableProvider();
20 virtual ~ObservableProvider(); 20 virtual ~ObservableProvider();
21 21
22 void AddObserver(Observer* observer); 22 void AddObserver(Observer* observer);
23 void RemoveObserver(Observer* observer); 23 void RemoveObserver(Observer* observer);
24 24
25 protected: 25 protected:
26 void NotifyObservers(ContentSettingsPattern primary_pattern, 26 void NotifyObservers(const ContentSettingsPattern& primary_pattern,
27 ContentSettingsPattern secondary_pattern, 27 const ContentSettingsPattern& secondary_pattern,
28 ContentSettingsType content_type, 28 ContentSettingsType content_type,
29 std::string resource_identifier); 29 std::string resource_identifier);
30 void RemoveAllObservers(); 30 void RemoveAllObservers();
31 31
32 private: 32 private:
33 ObserverList<Observer, true> observer_list_; 33 ObserverList<Observer, true> observer_list_;
34 }; 34 };
35 35
36 } // namespace content_settings 36 } // namespace content_settings
37 37
38 #endif // CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_OBSERVABLE_PROVIDER_ H_ 38 #endif // CHROME_BROWSER_CONTENT_SETTINGS_CONTENT_SETTINGS_OBSERVABLE_PROVIDER_ H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698