chrome/browser/content_settings/content_settings_observable_provider.cc - Issue 9159053: Coverity: pass ContentSettingsPattern by const ref

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_observable_provider.cc

Issue 9159053: Coverity: pass ContentSettingsPattern by const ref (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix MockObserver Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/content_settings_observable_provider.h ('k') | chrome/browser/content_settings/content_settings_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_observable_provider.cc

diff --git a/chrome/browser/content_settings/content_settings_observable_provider.cc b/chrome/browser/content_settings/content_settings_observable_provider.cc

index 98f91cbaea23916bb528d9af98dd3b6bb13e9464..59a63ce218e1f636b581e6103ca5e49739d67a6c 100644

--- a/chrome/browser/content_settings/content_settings_observable_provider.cc

+++ b/chrome/browser/content_settings/content_settings_observable_provider.cc

@@ -29,8 +29,8 @@ void ObservableProvider::RemoveAllObservers() {

}

void ObservableProvider::NotifyObservers(

- ContentSettingsPattern primary_pattern,

- ContentSettingsPattern secondary_pattern,

+ const ContentSettingsPattern& primary_pattern,

+ const ContentSettingsPattern& secondary_pattern,

ContentSettingsType content_type,

std::string resource_identifier) {

FOR_EACH_OBSERVER(Observer,