Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 9159053: Coverity: pass ContentSettingsPattern by const ref (Closed)

Created:
8 years, 10 months ago by Tyler Breisacher (Chromium)
Modified:
8 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Coverity: pass ContentSettingsPattern by const ref CID=100555 BUG= TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=120224

Patch Set 1 #

Patch Set 2 : fix MockObserver #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -12 lines) Patch
M chrome/browser/content_settings/content_settings_mock_observer.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_observable_provider.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_observable_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/content_settings_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/content_settings/host_content_settings_map.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Tyler Breisacher (Chromium)
8 years, 10 months ago (2012-01-31 00:41:44 UTC) #1
jochen (gone - plz use gerrit)
On 2012/01/31 00:41:44, tbreisacher wrote: can you run tryjobs please?
8 years, 10 months ago (2012-01-31 14:13:03 UTC) #2
Tyler Breisacher (Chromium)
I had already compiled chrome locally, but I didn't compile the unit tests. Sorry about ...
8 years, 10 months ago (2012-01-31 18:45:48 UTC) #3
jochen (gone - plz use gerrit)
On 2012/01/31 18:45:48, tbreisacher wrote: > I had already compiled chrome locally, but I didn't ...
8 years, 10 months ago (2012-02-01 08:39:58 UTC) #4
Tyler Breisacher (Chromium)
I'm getting a lot of failures, but they all look like they're unrelated to this ...
8 years, 10 months ago (2012-02-01 21:42:28 UTC) #5
jochen (gone - plz use gerrit)
8 years, 10 months ago (2012-02-02 10:45:32 UTC) #6
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698