Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 9150035: Address comment from https://chromiumcodereview.appspot.com/9150027: (Closed)

Created:
8 years, 11 months ago by Ivan Posva
Modified:
8 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Address comment from https://chromiumcodereview.appspot.com/9150027: - Add an _ between mode and arch in test configuration. Committed: https://code.google.com/p/dart/source/detail?r=3438

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Ivan Posva
TBR=whesse -Ivan
8 years, 11 months ago (2012-01-19 17:12:11 UTC) #1
Bill Hesse
LGTM.
8 years, 11 months ago (2012-01-19 17:56:00 UTC) #2
Mads Ager (google)
8 years, 11 months ago (2012-01-19 18:31:54 UTC) #3
LGTM, thanks!

Powered by Google App Engine
This is Rietveld 408576698