Add configuration information to test.dart output.

Add configuration information to test.dart output.


BUG=dart:1168
TEST=

Committed: https://code.google.com/p/dart/source/detail?r=3431

[Mads Ager (google), 2012-01-19 12:34:00]

lgtm

[Mads Ager (google), 2012-01-19 13:05:23]

http://codereview.chromium.org/9150027/diff/1/tools/testing/dart/test_runner....
File tools/testing/dart/test_runner.dart (right):

http://codereview.chromium.org/9150027/diff/1/tools/testing/dart/test_runner....
tools/testing/dart/test_runner.dart:80: configuration['mode'] +
configuration['arch'];
Sorry, this is a little late, but don't you want a space or underscore or
something between mode and arch:

debug ia32
debug_ia32

?

[Bill Hesse, 2012-01-19 13:06:46]

The bug reporter wanted the output that test.py had, which has them concatenated
without any separator.  I can ask if they care.

On 2012/01/19 13:05:23, Mads Ager wrote:
>
http://codereview.chromium.org/9150027/diff/1/tools/testing/dart/test_runner....
> File tools/testing/dart/test_runner.dart (right):
> 
>
http://codereview.chromium.org/9150027/diff/1/tools/testing/dart/test_runner....
> tools/testing/dart/test_runner.dart:80: configuration['mode'] +
> configuration['arch'];
> Sorry, this is a little late, but don't you want a space or underscore or
> something between mode and arch:
> 
> debug ia32
> debug_ia32
> 
> ?

[Ivan Posva, 2012-01-19 17:04:41]

https://chromiumcodereview.appspot.com/9150027/diff/1/tools/testing/dart/test...
File tools/testing/dart/test_runner.dart (right):

https://chromiumcodereview.appspot.com/9150027/diff/1/tools/testing/dart/test...
tools/testing/dart/test_runner.dart:80: configuration['mode'] +
configuration['arch'];
On 2012/01/19 13:05:23, Mads Ager wrote:
> Sorry, this is a little late, but don't you want a space or underscore or
> something between mode and arch:
> 
> debug ia32
> debug_ia32
> 
> ?

As the bug reporter all I want is some indication what configuration was running
or taking so much time. To me debug_ia32 is probably a bit more readable. I'll
fix it.

[Ivan Posva, 2012-01-19 17:14:14]

On 2012/01/19 17:04:41, Ivan Posva wrote:
>
https://chromiumcodereview.appspot.com/9150027/diff/1/tools/testing/dart/test...
> File tools/testing/dart/test_runner.dart (right):
> 
>
https://chromiumcodereview.appspot.com/9150027/diff/1/tools/testing/dart/test...
> tools/testing/dart/test_runner.dart:80: configuration['mode'] +
> configuration['arch'];
> On 2012/01/19 13:05:23, Mads Ager wrote:
> > Sorry, this is a little late, but don't you want a space or underscore or
> > something between mode and arch:
> > 
> > debug ia32
> > debug_ia32
> > 
> > ?
> 
> As the bug reporter all I want is some indication what configuration was
running
> or taking so much time. To me debug_ia32 is probably a bit more readable. I'll
> fix it.

Fixed in: https://chromiumcodereview.appspot.com/9150035