Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: testing/dart/test_runner.dart

Issue 9150035: Address comment from https://chromiumcodereview.appspot.com/9150027: (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/tools/
Patch Set: Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2011, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 #library("test_runner"); 5 #library("test_runner");
6 6
7 #import("status_file_parser.dart"); 7 #import("status_file_parser.dart");
8 #import("test_progress.dart"); 8 #import("test_progress.dart");
9 #import("test_suite.dart"); 9 #import("test_suite.dart");
10 10
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
70 suffixSplit.forEach((e) { 70 suffixSplit.forEach((e) {
71 if (!e.isEmpty()) newArguments.add(e); 71 if (!e.isEmpty()) newArguments.add(e);
72 }); 72 });
73 arguments = newArguments; 73 arguments = newArguments;
74 } 74 }
75 } 75 }
76 76
77 int get timeout() => configuration['timeout']; 77 int get timeout() => configuration['timeout'];
78 78
79 String get configurationString() => 79 String get configurationString() =>
80 configuration['mode'] + configuration['arch']; 80 "${configuration['mode']}_${configuration['arch']}";
81 81
82 void completed() { completedHandler(this); } 82 void completed() { completedHandler(this); }
83 } 83 }
84 84
85 85
86 /** 86 /**
87 * BrowserTestCase has an extra compilation command that is run by 87 * BrowserTestCase has an extra compilation command that is run by
88 * RunningProcess.start(), and it checks conditions on the test output 88 * RunningProcess.start(), and it checks conditions on the test output
89 * in TestOutput.didFail(). 89 * in TestOutput.didFail().
90 */ 90 */
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
543 test.displayName != 'dartc/junit_tests') { 543 test.displayName != 'dartc/junit_tests') {
544 _ensureDartcBatchRunnersStarted(test.executablePath); 544 _ensureDartcBatchRunnersStarted(test.executablePath);
545 _getDartcBatchRunnerProcess().startTest(test); 545 _getDartcBatchRunnerProcess().startTest(test);
546 } else { 546 } else {
547 new RunningProcess(test).start(); 547 new RunningProcess(test).start();
548 } 548 }
549 _numProcesses++; 549 _numProcesses++;
550 } 550 }
551 } 551 }
552 } 552 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698