Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 9150017: Add a Content API around BrowserChildProcessHost, similar to what was done with ChildProcessHost.... (Closed)

Created:
8 years, 11 months ago by jam
Modified:
8 years, 11 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, native-client-reviews_googlegroups.com, yusukes+watch_chromium.org, kkania, yoshiki+watch_chromium.org, jam, penghuang+watch_chromium.org, apatrick_chromium, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, darin-cc_chromium.org, robertshield, James Su, mihaip+watch_chromium.org
Visibility:
Public.

Description

Add a Content API around BrowserChildProcessHost, similar to what was done with ChildProcessHost. Now classes like PluginProcessHost don't derive from it, but instead use composition. I've also moved the iterator class into its own file in the public directory. Since classes don't derive from BrowserChildProcessHost and so can't static_cast from it, I added a template helper that does this. BUG=98716 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118415 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118516

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : fix mac and sync #

Patch Set 6 : sync again #

Patch Set 7 : after revert #

Patch Set 8 : fix?! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+802 lines, -495 lines) Patch
M chrome/browser/DEPS View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/automation/testing_automation_provider.cc View 1 2 3 4 5 6 3 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/browser_process_impl.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/debugger/devtools_sanity_unittest.cc View 1 2 3 4 5 6 5 chunks +10 lines, -12 lines 0 comments Download
M chrome/browser/extensions/extension_tabs_module.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/extensions/sandboxed_extension_unpacker_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/intents/web_intents_registry_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/memory_details.cc View 1 2 3 4 5 6 3 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/memory_details_linux.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_mac.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/memory_details_win.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 5 6 3 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.h View 1 2 3 4 5 6 2 chunks +11 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_broker_host_win.cc View 1 2 3 4 5 6 5 chunks +9 lines, -6 lines 0 comments Download
M chrome/browser/nacl_host/nacl_broker_service_win.cc View 1 2 3 4 5 6 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.h View 1 2 3 4 5 6 4 chunks +12 lines, -6 lines 0 comments Download
M chrome/browser/nacl_host/nacl_process_host.cc View 1 2 3 4 5 6 10 chunks +21 lines, -17 lines 0 comments Download
M chrome/browser/notifications/desktop_notification_service.cc View 1 2 3 4 5 6 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/task_manager/task_manager_resource_providers.cc View 1 2 3 4 5 6 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/task_manager/task_manager_worker_resource_provider.cc View 1 2 3 4 5 6 4 chunks +5 lines, -8 lines 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/intents/web_intents_model_unittest.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options/chromeos/user_image_source.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/user_image_source2.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/workers_ui.cc View 1 2 3 4 5 6 6 chunks +15 lines, -17 lines 0 comments Download
M chrome/browser/web_resource/web_resource_service.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M chrome/service/service_utility_process_host.h View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 2 3 4 5 6 2 chunks +0 lines, -7 lines 0 comments Download
M content/browser/browser_child_process_host.h View 1 2 3 4 5 6 2 chunks +41 lines, -96 lines 0 comments Download
M content/browser/browser_child_process_host.cc View 1 2 3 4 5 6 7 13 chunks +74 lines, -71 lines 0 comments Download
M content/browser/browser_process_sub_thread.cc View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M content/browser/content_ipc_logging.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.h View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/debugger/worker_devtools_manager.cc View 1 2 3 4 5 6 6 chunks +9 lines, -10 lines 0 comments Download
M content/browser/gpu/gpu_process_host.h View 1 2 3 4 5 6 5 chunks +15 lines, -11 lines 0 comments Download
M content/browser/gpu/gpu_process_host.cc View 1 2 3 4 5 6 12 chunks +14 lines, -13 lines 0 comments Download
M content/browser/plugin_process_host.h View 1 2 3 4 5 6 4 chunks +21 lines, -2 lines 0 comments Download
M content/browser/plugin_process_host.cc View 1 2 3 4 5 6 11 chunks +20 lines, -15 lines 0 comments Download
M content/browser/plugin_process_host_mac.cc View 1 2 3 4 5 6 3 chunks +6 lines, -2 lines 0 comments Download
M content/browser/plugin_service_impl.cc View 1 2 3 4 5 6 4 chunks +11 lines, -31 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.h View 1 2 3 4 5 6 4 chunks +30 lines, -3 lines 0 comments Download
M content/browser/ppapi_plugin_process_host.cc View 1 2 3 4 5 6 6 chunks +18 lines, -12 lines 0 comments Download
M content/browser/profiler_controller_impl.cc View 1 2 3 4 5 6 3 chunks +9 lines, -10 lines 0 comments Download
M content/browser/renderer_host/gpu_message_filter.cc View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_win.cc View 1 2 3 4 5 6 2 chunks +5 lines, -6 lines 0 comments Download
M content/browser/utility_process_host.h View 1 2 3 4 5 6 5 chunks +11 lines, -6 lines 0 comments Download
M content/browser/utility_process_host.cc View 1 2 3 4 5 6 6 chunks +8 lines, -6 lines 0 comments Download
M content/browser/worker_host/worker_process_host.h View 1 2 3 4 5 6 6 chunks +26 lines, -7 lines 0 comments Download
M content/browser/worker_host/worker_process_host.cc View 1 2 3 4 5 6 13 chunks +39 lines, -26 lines 0 comments Download
M content/browser/worker_host/worker_service_impl.cc View 1 2 3 4 5 6 11 chunks +29 lines, -48 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 1 chunk +5 lines, -0 lines 0 comments Download
M content/content_common.gypi View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/DEPS View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A content/public/browser/browser_child_process_host.h View 1 chunk +70 lines, -0 lines 0 comments Download
A content/public/browser/browser_child_process_host_delegate.h View 1 2 3 4 5 6 1 chunk +37 lines, -0 lines 0 comments Download
A content/public/browser/browser_child_process_host_delegate.cc View 1 chunk +13 lines, -0 lines 0 comments Download
A content/public/browser/browser_child_process_host_iterator.h View 1 chunk +68 lines, -0 lines 0 comments Download
A content/public/browser/browser_child_process_host_iterator.cc View 1 chunk +65 lines, -0 lines 0 comments Download
M content/public/common/child_process_host.h View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
M content/public/common/child_process_host_delegate.h View 1 2 3 4 5 6 2 chunks +11 lines, -10 lines 0 comments Download
A content/public/common/child_process_host_delegate.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
jam
8 years, 11 months ago (2012-01-19 21:41:25 UTC) #1
Elliot Glaysher
8 years, 11 months ago (2012-01-19 23:03:53 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698