chrome/browser/task_manager/task_manager_resource_providers.cc - Issue 9150017: Add a Content API around BrowserChildProcessHost, similar to what was done with ChildProcessHost....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/task_manager/task_manager_resource_providers.cc

Issue 9150017: Add a Content API around BrowserChildProcessHost, similar to what was done with ChildProcessHost.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/

Patch Set: fix?! Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.cc ('k') | chrome/browser/task_manager/task_manager_worker_resource_provider.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/task_manager/task_manager_resource_providers.cc

===================================================================

--- chrome/browser/task_manager/task_manager_resource_providers.cc (revision 118420)

+++ chrome/browser/task_manager/task_manager_resource_providers.cc (working copy)

@@ -41,9 +41,10 @@

#include "chrome/common/extensions/extension.h"

#include "chrome/common/render_messages.h"

#include "chrome/common/url_constants.h"

-#include "content/browser/browser_child_process_host.h"

#include "content/browser/renderer_host/render_view_host.h"

+#include "content/public/browser/browser_child_process_host_iterator.h"

#include "content/public/browser/browser_thread.h"

+#include "content/public/browser/child_process_data.h"

#include "content/public/browser/notification_service.h"

#include "content/public/browser/render_process_host.h"

#include "content/public/browser/web_contents.h"

@@ -64,6 +65,7 @@

#include "ui/gfx/icon_util.h"

#endif // defined(OS_WIN)

+using content::BrowserChildProcessHostIterator;

using content::BrowserThread;

using content::WebContents;

@@ -1068,11 +1070,11 @@

// The ChildProcessData::Iterator has to be used from the IO thread.

void TaskManagerChildProcessResourceProvider::RetrieveChildProcessData() {

std::vector<content::ChildProcessData> child_processes;

- for (BrowserChildProcessHost::Iterator iter; !iter.Done(); ++iter) {

+ for (BrowserChildProcessHostIterator iter; !iter.Done(); ++iter) {

// Only add processes which are already started, since we need their handle.

- if ((*iter)->data().handle == base::kNullProcessHandle)

+ if (iter.GetData().handle == base::kNullProcessHandle)

continue;

- child_processes.push_back((*iter)->data());

+ child_processes.push_back(iter.GetData());

}

// Now notify the UI thread that we have retrieved information about child

// processes.