Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: content/public/common/child_process_host_delegate.h

Issue 9150017: Add a Content API around BrowserChildProcessHost, similar to what was done with ChildProcessHost.... (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix?! Created 8 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/common/child_process_host.h ('k') | content/public/common/child_process_host_delegate.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/common/child_process_host_delegate.h
===================================================================
--- content/public/common/child_process_host_delegate.h (revision 118420)
+++ content/public/common/child_process_host_delegate.h (working copy)
@@ -2,12 +2,13 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#ifndef CONTENT_PULIC_COMMON_CHILD_PROCESS_HOST_DELEGATE_H_
-#define CONTENT_PULIC_COMMON_CHILD_PROCESS_HOST_DELEGATE_H_
+#ifndef CONTENT_PUBLIC_COMMON_CHILD_PROCESS_HOST_DELEGATE_H_
+#define CONTENT_PUBLIC_COMMON_CHILD_PROCESS_HOST_DELEGATE_H_
#pragma once
#include <string>
+#include "content/common/content_export.h"
#include "ipc/ipc_channel.h"
namespace content {
@@ -17,20 +18,20 @@
public:
virtual ~ChildProcessHostDelegate() {}
- // Derived classes return true if it's ok to shut down the child process.
- // Normally they would return true. The exception is if the host is in the
- // middle of sending a request to the process, in which case the other side
- // might think it's ok to shutdown, when really it's not.
- virtual bool CanShutdown() = 0;
+ // Delegates return true if it's ok to shut down the child process (which is
+ // the default return value). The exception is if the host is in the middle of
+ // sending a request to the process, in which case the other side might think
+ // it's ok to shutdown, when really it's not.
+ CONTENT_EXPORT virtual bool CanShutdown();
// Notifies the derived class that we told the child process to kill itself.
- virtual void ShutdownStarted() = 0;
+ virtual void ShutdownStarted() {}
// Called when the child process unexpected closes the IPC channel. Delegates
// would normally delete the object in this case.
- virtual void OnChildDisconnected() = 0;
+ virtual void OnChildDisconnected() {}
};
}; // namespace content
-#endif // CONTENT_PULIC_COMMON_CHILD_PROCESS_HOST_DELEGATE_H_
+#endif // CONTENT_PUBLIC_COMMON_CHILD_PROCESS_HOST_DELEGATE_H_
« no previous file with comments | « content/public/common/child_process_host.h ('k') | content/public/common/child_process_host_delegate.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698