content/browser/renderer_host/media/audio_sync_reader.cc - Issue 9121045: Switch AudioDevice classes from SyncSocket to CancelableSyncSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/audio_sync_reader.cc

Issue 9121045: Switch AudioDevice classes from SyncSocket to CancelableSyncSocket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, add temporary ScopedAllowIO for the audio thread cleanup+TODO for next cl. Created 8 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/renderer_host/media/audio_sync_reader.cc

diff --git a/content/browser/renderer_host/media/audio_sync_reader.cc b/content/browser/renderer_host/media/audio_sync_reader.cc

index c06345a6c80aa3370a7d962435ca8df3ce34f079..7b6664bbf49f81b8daa41ab455feb50f21a89e93 100644

--- a/content/browser/renderer_host/media/audio_sync_reader.cc

+++ b/content/browser/renderer_host/media/audio_sync_reader.cc

@@ -92,9 +92,10 @@ void AudioSyncReader::Close() {

}

bool AudioSyncReader::Init() {

- socket_.reset(new base::SyncSocket());

- foreign_socket_.reset(new base::SyncSocket());

- return base::SyncSocket::CreatePair(socket_.get(), foreign_socket_.get());

+ socket_.reset(new base::CancelableSyncSocket());

+ foreign_socket_.reset(new base::CancelableSyncSocket());

+ return base::CancelableSyncSocket::CreatePair(socket_.get(),

+ foreign_socket_.get());

}

#if defined(OS_WIN)