Issue 9117040: Prep for landing WK76487

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 9117040: Prep for landing WK76487 (Closed)

Created:
8 years, 11 months ago by jsbell

Modified:
8 years, 11 months ago

Reviewers:
michaeln, dgrogan

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Prep for landing WK76487 The patch for WebKit 76487 introduces NullType to the WebKit/Chromium WebIDBKey API to support calls that yield null WebCore::IDBKey pointers, which are subtly distinct in the spec from "invalid" results (IDBKey of InvalidType). This patch allows Chromium to build and pass tests with and without that WebKit patch, although some Indexed DB functionality will be broken until the subsequent Chromium patch (https://chromiumcodereview.appspot.com/9212038/) lands which updates test results and updates the IndexedDBKey to match the WebKit semantics. BUG=110956 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=118952

Patch Set 1 #

Patch Set 2 : Move default: label to last, add bug URL to TODO comment #

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
M	content/browser/in_process_webkit/indexed_db_browsertest.cc	View		1 chunk	+6 lines, -3 lines	0 comments	Download
M	content/browser/indexed_db/idbbindingutilities_browsertest.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/indexed_db/indexed_db_key.cc	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_param_traits.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

jsbell

Once everything has passed try and reviews, the plan is: 1. Land https://chromiumcodereview.appspot.com/9117040 (this) 2. ...

8 years, 11 months ago (2012-01-24 19:11:08 UTC) #1

michaeln

8 years, 11 months ago (2012-01-24 21:22:03 UTC) #2

lgtm
(a little odd seeing the default case not at the end of the switch, ok since
this is very transient)

Expand Messages | Collapse Messages