Issue 9212038: Distinguish null IDBKey (no value) and invalid IDBKey (value is not valid key)

Issue 9212038: Distinguish null IDBKey (no value) and invalid IDBKey (value is not valid key) (Closed)

Created:
8 years, 11 months ago by jsbell

Modified:
8 years, 11 months ago

Reviewers:
michaeln, leviw_travelin_and_unemployed, darin (slow to review), dgrogan, tony

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Distinguish null IDBKey (no value) and invalid IDBKey (value is not valid key) WebKit change is https://bugs.webkit.org/show_bug.cgi?id=76487 Browser tests are updated and extended to validate null vs. invalid paths. The IndexedDBKey type is updated to support null in addition to invalid, and key path parsing failures now yield nulls. BUG=110956, 111431 TEST= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=119183

Created: 8 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+103 lines, -54 lines)			Patch
M	content/browser/in_process_webkit/indexed_db_browsertest.cc	View	1	1 chunk	+3 lines, -6 lines	0 comments	Download
M	content/browser/in_process_webkit/indexed_db_uitest.cc	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/indexed_db/idbbindingutilities_browsertest.cc	View	1	7 chunks	+85 lines, -34 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_key.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_key.cc	View	1	3 chunks	+7 lines, -4 lines	0 comments	Download
M	content/common/indexed_db/indexed_db_param_traits.cc	View	1	2 chunks	+4 lines, -6 lines	0 comments	Download
M	webkit/glue/idb_bindings.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

dgrogan

Could you re-enable IndexedDBUILayoutTest.LayoutTests in this change and add 111431 to the BUG= line?

8 years, 11 months ago (2012-01-26 01:29:07 UTC) #2

jsbell

On 2012/01/26 01:29:07, dgrogan wrote: > Could you re-enable IndexedDBUILayoutTest.LayoutTests in this change and add ...

8 years, 11 months ago (2012-01-26 02:28:25 UTC) #3

jsbell

darin@ or tony@ - can I get an OWNERS review of the webkit/glue change?

8 years, 11 months ago (2012-01-26 03:19:53 UTC) #4

rs LGTM