chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm - Issue 884373002: Update content setting for app banners to store more information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

Issue 884373002: Update content setting for app banners to store more information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac test failure Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_settings_helper.h ('K') | « chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm ('k') | chrome/browser/ui/webui/options/content_settings_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

index 4c22de1a859c538d6562347e6a8732ee05ce2003..2d318140a467ab602c48ef93843199ddbe58cbd6 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm

@@ -113,7 +113,8 @@ TEST_F(ContentSettingBubbleControllerTest, Init) {

i == CONTENT_SETTINGS_TYPE_PPAPI_BROKER ||

i == CONTENT_SETTINGS_TYPE_MIDI_SYSEX ||

i == CONTENT_SETTINGS_TYPE_PUSH_MESSAGING ||

- i == CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS) {

+ i == CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS ||

+ i == CONTENT_SETTINGS_TYPE_APP_BANNER) {

// These types have no bubble.

continue;

}