chrome/browser/ui/webui/options/content_settings_handler.cc - Issue 884373002: Update content setting for app banners to store more information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/content_settings_handler.cc

Issue 884373002: Update content setting for app banners to store more information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac test failure Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_settings_helper.h ('K') | « chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm ('k') | chrome/chrome_browser.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/content_settings_handler.cc

diff --git a/chrome/browser/ui/webui/options/content_settings_handler.cc b/chrome/browser/ui/webui/options/content_settings_handler.cc

index 64a3c3fa49ba27e8eacc482529a6f4a21b229c1b..751c23163608fb9afabcc3b4e67c5560eed516fe 100644

--- a/chrome/browser/ui/webui/options/content_settings_handler.cc

+++ b/chrome/browser/ui/webui/options/content_settings_handler.cc

@@ -746,6 +746,11 @@ void ContentSettingsHandler::UpdateExceptionsViewFromModel(

case CONTENT_SETTINGS_TYPE_METRO_SWITCH_TO_DESKTOP:

break;

#endif

+ case CONTENT_SETTINGS_TYPE_APP_BANNER:

+ // The content settings type CONTENT_SETTINGS_TYPE_APP_BANNER is used to

+ // track whether app banners should be shown or not, and is not a user

+ // visible content setting.

+ break;

default:

UpdateExceptionsViewFromHostContentSettingsMap(type);

break;