chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm - Issue 884373002: Update content setting for app banners to store more information.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

Issue 884373002: Update content setting for app banners to store more information. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Mac test failure Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/banners/app_banner_settings_helper.h ('K') | « chrome/browser/banners/app_banner_settings_helper_unittest.cc ('k') | chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

index 99352b84cf7edd765fe00de578488dd4349eb0c6..65937f89a5a5e02a2628252e9bfae5efab5baa25 100644

--- a/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

+++ b/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm

@@ -285,6 +285,7 @@ class ContentSettingBubbleWebContentsObserverBridge

// is implemented

case CONTENT_SETTINGS_TYPE_PUSH_MESSAGING:

case CONTENT_SETTINGS_TYPE_SSL_CERT_DECISIONS:

+ case CONTENT_SETTINGS_TYPE_APP_BANNER:

NOTREACHED();

}

if ((self = [super initWithWindowNibPath:nibPath