Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 846133002: Put conditional operators on the left. (Closed)

Created:
5 years, 11 months ago by Bob Nystrom
Modified:
5 years, 11 months ago
Reviewers:
pquitslund
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dart_style.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Put conditional operators on the left. R=pquitslund@google.com Committed: ce238503e32b3ffde01247d3c5b956567c61e019

Patch Set 1 #

Patch Set 2 : Update version. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+66 lines, -58 lines) Patch
M CHANGELOG.md View 1 1 chunk +4 lines, -0 lines 0 comments Download
M lib/src/source_visitor.dart View 1 chunk +6 lines, -4 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +1 line, -1 line 0 comments Download
M test/regression/112.stmt View 2 chunks +7 lines, -7 lines 0 comments Download
M test/regression/115.stmt View 1 chunk +3 lines, -3 lines 0 comments Download
M test/regression/122.unit View 2 chunks +8 lines, -8 lines 0 comments Download
M test/regression/44.stmt View 1 chunk +3 lines, -3 lines 0 comments Download
M test/regression/45.stmt View 1 chunk +3 lines, -3 lines 0 comments Download
M test/regression/80.unit View 1 chunk +18 lines, -16 lines 0 comments Download
M test/splitting/expressions.stmt View 2 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Bob Nystrom
After this lands, I'll cut a release and bring it into the repo.
5 years, 11 months ago (2015-01-12 22:45:12 UTC) #2
pquitslund
LGTM!
5 years, 11 months ago (2015-01-12 22:46:31 UTC) #3
Bob Nystrom
5 years, 11 months ago (2015-01-12 22:46:59 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ce238503e32b3ffde01247d3c5b956567c61e019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698