test/regression/80.unit - Issue 846133002: Put conditional operators on the left.

Side by Side Diff: test/regression/80.unit

Issue 846133002: Put conditional operators on the left. (Closed) Base URL: https://github.com/dart-lang/dart_style.git@master

Patch Set: Update version. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 >>>	1 >>>

2 void main(List argv) {	2 void main(List argv) {

3 // This is ok (it moves the ? and : to the ends of the previous lines)	3 // This is ok (it moves the ? and : to the ends of the previous lines)

4 var cg = outputDart	4 var cg = outputDart

5 ? new A(	5 ? new A(

6 outputDir, uri, results.libraries, results.infoMap, results.rules,	6 outputDir, uri, results.libraries, results.infoMap, results.rules,

7 formatOutput)	7 formatOutput)

8 : new B(	8 : new B(

9 outputDir, uri, results.libraries, results.infoMap, results.rules);	9 outputDir, uri, results.libraries, results.infoMap, results.rules);

10	10

(...skipping 22 matching lines...) Expand all Loading...
33 new ALongerClass(	33 new ALongerClass(

34 outputDir, uri, results.libraries, results.infoMap, results.rules,	34 outputDir, uri, results.libraries, results.infoMap, results.rules,

35 formatOutput) :	35 formatOutput) :

36 new BLongerClass(	36 new BLongerClass(

37 outputDir, uri, results.libraries, results.infoMap, results.rules);	37 outputDir, uri, results.libraries, results.infoMap, results.rules);

38	38

39 }	39 }

40 <<<	40 <<<

41 void main(List argv) {	41 void main(List argv) {

42 // This is ok (it moves the ? and : to the ends of the previous lines)	42 // This is ok (it moves the ? and : to the ends of the previous lines)

43 var cg = outputDart ?	43 var cg = outputDart

44 new A(outputDir, uri, results.libraries, results.infoMap, results.rules,	44 ? new A(outputDir, uri, results.libraries, results.infoMap, results.rules,

45 formatOutput) :	45 formatOutput)

46 new B(outputDir, uri, results.libraries, results.infoMap, results.rules);	46 : new B(

	47 outputDir, uri, results.libraries, results.infoMap, results.rules);

47	48

48 // This gets rewritten to something much harder to read	49 // This gets rewritten to something much harder to read

49 // var cg = outputDart ?	50 // var cg = outputDart ?

50 // new ALongerClass(outputDir, uri, results.libraries, results.infoMap,	51 // new ALongerClass(outputDir, uri, results.libraries, results.infoMap,

51 // results.rules, formatOutput) : new BLongerClass(	52 // results.rules, formatOutput) : new BLongerClass(

52 // outputDir, uri, results.libraries, results.infoMap, results.rules);	53 // outputDir, uri, results.libraries, results.infoMap, results.rules);

53 var cg = outputDart ?	54 var cg = outputDart

54 new ALongerClass(outputDir, uri, results.libraries, results.infoMap,	55 ? new ALongerClass(outputDir, uri, results.libraries, results.infoMap,

55 results.rules, formatOutput) :	56 results.rules, formatOutput)

56 new BLongerClass(	57 : new BLongerClass(

57 outputDir, uri, results.libraries, results.infoMap, results.rules);	58 outputDir, uri, results.libraries, results.infoMap, results.rules);

58	59

59 // OK, left unchanged	60 // OK, left unchanged

60 var cg = outputDart ?	61 var cg = outputDart

61 new A(outputDir, uri, results.libraries, results.infoMap, results.rules,	62 ? new A(outputDir, uri, results.libraries, results.infoMap, results.rules,

62 formatOutput) :	63 formatOutput)

63 new B(outputDir, uri, results.libraries, results.infoMap, results.rules);	64 : new B(

	65 outputDir, uri, results.libraries, results.infoMap, results.rules);

64	66

65 // Bad, as above	67 // Bad, as above

66 var cg = outputDart ?	68 var cg = outputDart

67 new ALongerClass(outputDir, uri, results.libraries, results.infoMap,	69 ? new ALongerClass(outputDir, uri, results.libraries, results.infoMap,

68 results.rules, formatOutput) :	70 results.rules, formatOutput)

69 new BLongerClass(	71 : new BLongerClass(

70 outputDir, uri, results.libraries, results.infoMap, results.rules);	72 outputDir, uri, results.libraries, results.infoMap, results.rules);

71 }	73 }

OLD	NEW

« no previous file with comments | « test/regression/45.stmt ('k') | test/splitting/expressions.stmt » ('j') | no next file with comments »