Allow constants as field initial values as well as creation thunks

Allow constants as field initial values as well as creation thunks

This change is paired with https://chromiumcodereview.appspot.com/813373003/

R=sigmund@google.com

Committed: https://github.com/dart-lang/protobuf/commit/74513c4632fbccadb804eb069048decfa0e9cf37

[sra1, 2014-12-19 17:55:31]

sra@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2014-12-19 21:53:38]

lgtm

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart
File lib/protobuf.dart (right):

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart...
lib/protobuf.dart:29: // TODO(sra): Remove this method when clients upgrade to
protoc 0.3.5
add @deprecated.

Alternatively, you can bump this as a breaking change (0.4.0) and require it in
protoc 0.3.5.

People should then be protected by the fact that the version increase was a
breaking change. If we fear that some people depend on protobuflib transitively
(they shouldn't but some people might), then we can make it a breaking change in
protoc as well.

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart...
lib/protobuf.dart:32: // TODO(http://dartbug.com/21915): Use Int64.parse() when
available.
nit: format the todo with your username, as follows:

// TODO(sra): Use .... See dartbug.com/21915

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/src/protobuf/...
File lib/src/protobuf/field_info.dart (right):

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/src/protobuf/...
lib/src/protobuf/field_info.dart:27: if (defaultOrMaker is Function) return
defaultOrMaker;
is Function => is MakeDefaultFunc ?

[sra1, 2014-12-19 23:15:55]

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart
File lib/protobuf.dart (right):

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart...
lib/protobuf.dart:29: // TODO(sra): Remove this method when clients upgrade to
protoc 0.3.5
On 2014/12/19 21:53:37, Siggi Cherem (dart-lang) wrote:
> add @deprecated.
> 
> Alternatively, you can bump this as a breaking change (0.4.0) and require it
in
> protoc 0.3.5.
> 
> People should then be protected by the fact that the version increase was a
> breaking change. If we fear that some people depend on protobuflib
transitively
> (they shouldn't but some people might), then we can make it a breaking change
in
> protoc as well.

This CL can land ahead of the protoc one.
I don't think it should me marked as deprecated until I land protoc 0.3.5
There is not much a user can do about the use of deprecated functions in
generated code.

https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart...
lib/protobuf.dart:32: // TODO(http://dartbug.com/21915): Use Int64.parse() when
available.
On 2014/12/19 21:53:38, Siggi Cherem (dart-lang) wrote:
> nit: format the todo with your username, as follows:
> 
> // TODO(sra): Use .... See dartbug.com/21915

Done.

[sra1, 2014-12-19 23:17:56]

Committed patchset #3 (id:40001) manually as
74513c4632fbccadb804eb069048decfa0e9cf37 (presubmit successful).