Protobuf changes for smaller dart2js code, Int64 fixes

Protobuf changes for smaller dart2js code, Int64 fixes

This change is paired with https://chromiumcodereview.appspot.com/814213003

Reduces code size for one app by 0.9%

1. Allow constants for the default value to avoid many trivial closures.
2. Generate and use static M.create() and M.createRepeated() methods on message classes M to ensure there is a shared copy of these closures rather than one copy per use.
3. Parse Int64 values rather than generate from 'int' to ensure no truncation errors in JavaScript.

R=sigmund@google.com

Committed: https://github.com/dart-lang/protoc-plugin/commit/fec382b4a8574ecbd17e18be89fb16ad807f064f

[sra1, 2014-12-19 17:54:42]

sra@google.com changed reviewers:
+ sigmund@google.com

[sra1, 2014-12-19 18:26:15]

https://chromiumcodereview.appspot.com/813373003/diff/1/pubspec.yaml
File pubspec.yaml (right):

https://chromiumcodereview.appspot.com/813373003/diff/1/pubspec.yaml#newcode13
pubspec.yaml:13: dependency_overrides:
I will delete this :-)

[Siggi Cherem (dart-lang), 2014-12-19 21:53:14]

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
File lib/message_generator.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
lib/message_generator.dart:112: } else if (field.group) {
after chatting about it - seems we can do the same here for groups too

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
lib/message_generator.dart:114: subBuilderRepeated = '()${SP}=>${SP}new
PbList<${fieldType}>()';
not for this CL, but I'll ask since I'm thinking about it here. I haven't read
this code in a long time - any reason why we are using $SP at all? it seems just
noise... 

Søren - do you know of any reasons for it?

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/protobuf_fiel...
File lib/protobuf_field.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/protobuf_fiel...
lib/protobuf_field.dart:283: initialization = '()${SP}=>${SP}new ${baseType}()';
and probably change here too

https://chromiumcodereview.appspot.com/813373003/diff/20001/test/generated_me...
File test/generated_message_test.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/test/generated_me...
test/generated_message_test.dart:23: import '../out/protos/toplevel.pb.dart';
to validate groups, it might be good to add a new .proto file that uses this
explicitly in test/protos/ and then validate below that it works.

[sra1, 2014-12-19 23:11:02]

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
File lib/message_generator.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
lib/message_generator.dart:112: } else if (field.group) {
On 2014/12/19 21:53:14, Siggi Cherem (dart-lang) wrote:
> after chatting about it - seems we can do the same here for groups too

Done.

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/protobuf_fiel...
File lib/protobuf_field.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/protobuf_fiel...
lib/protobuf_field.dart:283: initialization = '()${SP}=>${SP}new ${baseType}()';
On 2014/12/19 21:53:14, Siggi Cherem (dart-lang) wrote:
> and probably change here too

Done.

https://chromiumcodereview.appspot.com/813373003/diff/20001/test/generated_me...
File test/generated_message_test.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/test/generated_me...
test/generated_message_test.dart:23: import '../out/protos/toplevel.pb.dart';
On 2014/12/19 21:53:14, Siggi Cherem (dart-lang) wrote:
> to validate groups, it might be good to add a new .proto file that uses this
> explicitly in test/protos/ and then validate below that it works.

proto TestAllTypes already has groups and various states are tested in
test_util.dart.

[Siggi Cherem (dart-lang), 2014-12-19 23:30:17]

lgtm

[sra1, 2014-12-19 23:33:25]

Committed patchset #3 (id:40001) manually as
fec382b4a8574ecbd17e18be89fb16ad807f064f (presubmit successful).

[Søren Gjesse, 2015-01-05 16:00:06]

sgjesse@google.com changed reviewers:
+ sgjesse@google.com

[Søren Gjesse, 2015-01-05 16:00:07]

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
File lib/message_generator.dart (right):

https://chromiumcodereview.appspot.com/813373003/diff/20001/lib/message_gener...
lib/message_generator.dart:114: subBuilderRepeated = '()${SP}=>${SP}new
PbList<${fieldType}>()';
On 2014/12/19 21:53:14, Siggi Cherem (dart-lang) wrote:
> not for this CL, but I'll ask since I'm thinking about it here. I haven't read
> this code in a long time - any reason why we are using $SP at all? it seems
just
> noise... 
> 
> Søren - do you know of any reasons for it?

I don't see any reason for using ${SP} when generating the code. I think this
dates back several years, and everybody (including me) have just kept that
style. I will be great to just change it to spaces.