Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(13)

Issue 814213003: Allow constants as field initial values as well as creation thunks (Closed)

Created:
4 years, 12 months ago by sra1
Modified:
4 years, 12 months ago
CC:
reviews_dartlang.org, Søren Gjesse
Base URL:
https://github.com/dart-lang/dart-protobuf@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow constants as field initial values as well as creation thunks This change is paired with https://chromiumcodereview.appspot.com/813373003/ R=sigmund@google.com Committed: https://github.com/dart-lang/protobuf/commit/74513c4632fbccadb804eb069048decfa0e9cf37

Patch Set 1 #

Patch Set 2 : make compatible with 0.3.3 #

Total comments: 5

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -17 lines) Patch
M lib/protobuf.dart View 1 2 1 chunk +9 lines, -0 lines 0 comments Download
M lib/src/protobuf/builder_info.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M lib/src/protobuf/extension.dart View 2 chunks +2 lines, -3 lines 0 comments Download
M lib/src/protobuf/field_info.dart View 1 2 1 chunk +8 lines, -3 lines 0 comments Download
M lib/src/protobuf/generated_message.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
sra1
4 years, 12 months ago (2014-12-19 17:55:48 UTC) #2
Siggi Cherem (dart-lang)
lgtm https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart File lib/protobuf.dart (right): https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart#newcode29 lib/protobuf.dart:29: // TODO(sra): Remove this method when clients upgrade ...
4 years, 12 months ago (2014-12-19 21:53:38 UTC) #3
sra1
https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart File lib/protobuf.dart (right): https://chromiumcodereview.appspot.com/814213003/diff/20001/lib/protobuf.dart#newcode29 lib/protobuf.dart:29: // TODO(sra): Remove this method when clients upgrade to ...
4 years, 12 months ago (2014-12-19 23:15:55 UTC) #4
sra1
4 years, 12 months ago (2014-12-19 23:17:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
74513c4632fbccadb804eb069048decfa0e9cf37 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698