Editing Sam's downloads page

Editing Sam's downloads page

Staged at:
https://issue-969-new-downloads-page-dot-dart-lang.appspot.com/tools/download.html

(Sorry, Sam, I accidentally overwrote your version.)

I recommend opening 3 copies—one for each platform—and comparing to the original(s) at https://www.dartlang.org/tools/download.html.

Committed: 40a27014641dc2879ad8a41f4ef5a31eebb27b7e

[Kathy Walrath, 2014-11-04 19:52:29]

kathyw@google.com changed reviewers:
+ sethladd@google.com, shaza@google.com, srawlins@google.com

[Kathy Walrath, 2014-11-04 19:52:29]

kathyw@google.com changed required reviewers:
+ srawlins@google.com

[Kathy Walrath, 2014-11-04 19:54:27]

Sam, could you please review this? You should probably compare it to your
version, which you probably have running locally but I deleted the published
one. Oops. Feel free to upload it to a different version name.

Seth & Sharon, I'd welcome your reviews, too.

I still haven't figured out the A-B testing stuff, so this isn't the version
that'll go out.

[Kathy Walrath, 2014-11-05 00:07:02]

On 2014/11/04 19:54:27, Kathy Walrath wrote:
> Sam, could you please review this? You should probably compare it to your
> version, which you probably have running locally but I deleted the published
> one. Oops. Feel free to upload it to a different version name.
> 
> Seth & Sharon, I'd welcome your reviews, too.
> 
> I still haven't figured out the A-B testing stuff, so this isn't the version
> that'll go out.

I've added
https://issue-969-new-downloads-page-dot-dart-lang.appspot.com/tools/download...
(the original downloads page) as a possible target for A-B testing.

[sethladd, 2014-11-05 00:28:23]

Good idea. Would love to get A/B testing into our infrastructure. We can then be
more bold in making changing, checking data, and seeing if we were right :)

[srawlins, 2014-11-05 18:38:22]

The copy looks great Kathy! I have three small comments. I love it overall.

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
File src/site/_includes/downloads/_macos_section.html (right):

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
src/site/_includes/downloads/_macos_section.html:32: you don't need to download
`dartium`.
I think in this context, with Homebrew, 'download' should be 'install'.

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
src/site/_includes/downloads/_macos_section.html:33: Just `brew install dart`.
IMHO this isn't necessary.

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
src/site/_includes/downloads/_macos_section.html:45: An alternative to using
Homebrew or Dart Editor
"or Dart Editor": Dart Editor hasn't been introduced yet. This might be
confusing here.

[Kathy Walrath, 2014-11-05 19:52:11]

ptal

I think I might leave the "download-orig.html" page there for a little while but
not point to it. I'll file a bug to remove it.

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
File src/site/_includes/downloads/_macos_section.html (right):

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
src/site/_includes/downloads/_macos_section.html:32: you don't need to download
`dartium`.
On 2014/11/05 18:38:22, srawlins wrote:
> I think in this context, with Homebrew, 'download' should be 'install'.

Done.

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
src/site/_includes/downloads/_macos_section.html:33: Just `brew install dart`.
On 2014/11/05 18:38:22, srawlins wrote:
> IMHO this isn't necessary.

Done.

https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
src/site/_includes/downloads/_macos_section.html:45: An alternative to using
Homebrew or Dart Editor
On 2014/11/05 18:38:22, srawlins wrote:
> "or Dart Editor": Dart Editor hasn't been introduced yet. This might be
> confusing here.

It's mentioned at the top in bold font, so I hoped that would be clue enough,
even though it's easy to miss.

[srawlins, 2014-11-05 22:51:20]

On 2014/11/05 19:52:11, Kathy Walrath wrote:
> ptal
> 
> I think I might leave the "download-orig.html" page there for a little while
but
> not point to it. I'll file a bug to remove it.
> 
>
https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
> File src/site/_includes/downloads/_macos_section.html (right):
> 
>
https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
> src/site/_includes/downloads/_macos_section.html:32: you don't need to
download
> `dartium`.
> On 2014/11/05 18:38:22, srawlins wrote:
> > I think in this context, with Homebrew, 'download' should be 'install'.
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
> src/site/_includes/downloads/_macos_section.html:33: Just `brew install dart`.
> On 2014/11/05 18:38:22, srawlins wrote:
> > IMHO this isn't necessary.
> 
> Done.
> 
>
https://chromiumcodereview.appspot.com/701913002/diff/40001/src/site/_include...
> src/site/_includes/downloads/_macos_section.html:45: An alternative to using
> Homebrew or Dart Editor
> On 2014/11/05 18:38:22, srawlins wrote:
> > "or Dart Editor": Dart Editor hasn't been introduced yet. This might be
> > confusing here.
> 
> It's mentioned at the top in bold font, so I hoped that would be clue enough,
> even though it's easy to miss.

Oops, you're right :P I missed it.

[Kathy Walrath, 2014-11-06 18:53:16]

Committed patchset #4 (id:60001) manually as
40a27014641dc2879ad8a41f4ef5a31eebb27b7e (presubmit successful).