Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: src/site/js/os-switcher.js

Issue 701913002: Editing Sam's downloads page (Closed) Base URL: https://github.com/dart-lang/www.dartlang.org.git@master
Patch Set: incorporate Sam's review comments Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/site/js/download-info.js ('k') | src/site/tools/download.markdown » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/site/js/os-switcher.js
diff --git a/src/site/js/os-switcher.js b/src/site/js/os-switcher.js
index 8ee05753c8c1f477ec255719c36422000110b213..c2488db491b10abbe8afb3ee07ff0eaf92d00de3 100644
--- a/src/site/js/os-switcher.js
+++ b/src/site/js/os-switcher.js
@@ -12,39 +12,48 @@ $(document).ready(function() {
}
}
- function filterPlatformText(showId) {
+ function filterPlatformText(showId) {
// Get all the platform-specific elements.
for (var i = 0; i < osList.length; i++) {
var os = osList[i];
var shouldShow = (os === showId);
- $('.' + os).each(function(i, el) {
- if (shouldShow) {
- $(el).show();
- } else {
- $(el).hide();
- }
- });
+ $('.' + os).each(function(i, el) { $(el).toggle(shouldShow); });
}
}
+ function resetButtons(el) {
+ if (el.tagName == "BUTTON") {
+ $('.btn-group.os-choices button').removeClass('active').addClass('inactive');
+ }
+ $(el).removeClass('inactive').addClass('active');
+ }
+
function registerHandlers() {
for (var i = 0; i < osList.length; i++) {
var os = document.getElementById(osList[i]);
if (os) {
os.addEventListener('click', function(e) {
filterPlatformText(e.target.id);
+ resetButtons(e.target);
});
}
}
}
var defaultOs = detectPlatform();
- var defaultOsElem = document.getElementById(defaultOs);
$('.' + defaultOs+'-option').prop('selected', true);
- if (defaultOsElem) {
- defaultOsElem.setAttribute('checked', 'checked');
- filterPlatformText(defaultOs);
- registerHandlers();
+ var defaultOsElem;
+ defaultOsElem = $('input#' + defaultOs);
+ if (defaultOsElem.length > 0) {
+ defaultOsElem.attr('checked', 'checked')
}
+ defaultOsElem = $('button#' + defaultOs);
+ if (defaultOsElem.length > 0) {
+ resetButtons(defaultOsElem[0]);
+ }
+ //if (defaultOsElem.length > 0) {
+ filterPlatformText(defaultOs);
+ registerHandlers();
+ //}
});
« no previous file with comments | « src/site/js/download-info.js ('k') | src/site/tools/download.markdown » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698