chrome/browser/extensions/api/chrome_extensions_api_client.h - Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/chrome_extensions_api_client.h

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change CreateChromeExtensionWebContentsObserver to DidInitialize Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/browser/extensions/api/chrome_extensions_api_client.cc » ('j') | chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/chrome_extensions_api_client.h

diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.h b/chrome/browser/extensions/api/chrome_extensions_api_client.h

index b3e29bb4a197320bdcb213178b2994d9bfd3ab5d..384b1b48eb159c865e092ffc247a1c6512072ed1 100644

--- a/chrome/browser/extensions/api/chrome_extensions_api_client.h

+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.h

@@ -24,8 +24,8 @@ class ChromeExtensionsAPIClient : public ExtensionsAPIClient {

std::map<settings_namespace::Namespace, ValueStoreCache*>* caches)

OVERRIDE;

virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const OVERRIDE;

- virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate()

- const OVERRIDE;

+ virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate(

+ ExtensionOptionsGuest* guest) const OVERRIDE;

virtual scoped_ptr<MimeHandlerViewGuestDelegate>

CreateMimeHandlerViewGuestDelegate(

MimeHandlerViewGuest* guest) const OVERRIDE;