chrome/browser/extensions/api/chrome_extensions_api_client.cc - Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/chrome_extensions_api_client.cc

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change CreateChromeExtensionWebContentsObserver to DidInitialize Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/chrome_extensions_api_client.h ('k') | chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h » ('j') | chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/chrome_extensions_api_client.cc

diff --git a/chrome/browser/extensions/api/chrome_extensions_api_client.cc b/chrome/browser/extensions/api/chrome_extensions_api_client.cc

index 493dfa1676b7f3f8abe263661e32bba06ceab28a..4132234fdc669cf0fc2796dc779170a708966bc5 100644

--- a/chrome/browser/extensions/api/chrome_extensions_api_client.cc

+++ b/chrome/browser/extensions/api/chrome_extensions_api_client.cc

@@ -49,8 +49,9 @@ AppViewGuestDelegate* ChromeExtensionsAPIClient::CreateAppViewGuestDelegate()

}

ExtensionOptionsGuestDelegate*

-ChromeExtensionsAPIClient::CreateExtensionOptionsGuestDelegate() const {

- return new ChromeExtensionOptionsGuestDelegate();

+ChromeExtensionsAPIClient::CreateExtensionOptionsGuestDelegate(

+ ExtensionOptionsGuest* guest) const {

+ return new ChromeExtensionOptionsGuestDelegate(guest);

}

scoped_ptr<MimeHandlerViewGuestDelegate>