chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h - Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change CreateChromeExtensionWebContentsObserver to DidInitialize Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/chrome_extensions_api_client.cc ('k') | chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc » ('j') | extensions/browser/guest_view/extension_options/extension_options_guest_delegate.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

diff --git a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

index b23d748c5f4d3cbd3d4060ce966751a57701c9da..53ae749e94b194b6c332e40bc8440fa019bfa7bc 100644

--- a/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

+++ b/chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.h

@@ -8,24 +8,22 @@

#include "extensions/browser/guest_view/extension_options/extension_options_guest_delegate.h"

#include "base/macros.h"

+#include "extensions/browser/guest_view/extension_options/extension_options_guest.h"

Yoyo Zhou 2014/09/11 20:17:26 Can you forward declare ExtensionOptionsGuest?

namespace extensions {

class ChromeExtensionOptionsGuestDelegate

: public ExtensionOptionsGuestDelegate {

public:

- ChromeExtensionOptionsGuestDelegate();

+ explicit ChromeExtensionOptionsGuestDelegate(ExtensionOptionsGuest* guest);

virtual ~ChromeExtensionOptionsGuestDelegate();

- virtual void CreateChromeExtensionWebContentsObserver(

- content::WebContents* web_contents) OVERRIDE;

+ virtual void DidInitialize() OVERRIDE;

virtual bool HandleContextMenu(

- content::WebContents* web_contents,

const content::ContextMenuParams& params) OVERRIDE;

virtual content::WebContents* OpenURLInNewTab(

- content::WebContents* embedder_web_contents,

const content::OpenURLParams& params) OVERRIDE;

private: