Add mojo python bindings tests to the waterfalls.

Add mojo python bindings tests to the waterfalls.

This is a reland of https://chromiumcodereview.appspot.com/518663003/ with the following changes:
- Adding build dependency to the new test
- Bundling generated python file from the build

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291902

[Dirk Pranke, 2014-09-08 22:07:38]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2014-09-08 22:07:39]

It would be good if, when re-landing a change like this, you would reference the
original CL that was reverted and describe what you've changed in the second
attempt.

I usually try to do this by re-uploading the original-patch as-is, and then
uploading a second patch so that I can easily review the diff. I would also
include links to the original CL or revert in either the description or at least
the messages.

That said, from what i can tell, the main change from the original CL is the
changes in zip_build.py, right? And so you're running tests that need to be able
to import stuff in out/gen, and that wouldn't exist without adding stuff to the
zip file?

(I didn't really stare at this code before, my bad for not being clear what was
going on ...)

[qsr, 2014-09-09 07:59:16]

> It would be good if, when re-landing a change like this, you would reference
the
> original CL that was reverted and describe what you've changed in the second
> attempt.
> 
> I usually try to do this by re-uploading the original-patch as-is, and then
> uploading a second patch so that I can easily review the diff. I would also
> include links to the original CL or revert in either the description or at
least
> the messages.

 Modified the description, and also uploaded the original as patchset 2.

> That said, from what i can tell, the main change from the original CL is the
> changes in zip_build.py, right? And so you're running tests that need to be
able
> to import stuff in out/gen, and that wouldn't exist without adding stuff to
the
> zip file?

 Correct. And also my original CL was missing some dependency from my test to
some target that needed to be build.

> 
> (I didn't really stare at this code before, my bad for not being clear what
was
> going on ...)

[Dirk Pranke, 2014-09-09 19:50:37]

lgtm

https://chromiumcodereview.appspot.com/550203002/diff/40001/scripts/slave/zip...
File scripts/slave/zip_build.py (right):

https://chromiumcodereview.appspot.com/550203002/diff/40001/scripts/slave/zip...
scripts/slave/zip_build.py:144: def MojomFiles(build_dir, suffixes=None):
Nit: there's only one caller of this routine. I'd make suffixes be a required
parameter. (I'd also rename this to _MojomFiles to make it clearer that nothing
outside of this script calls this).

[qsr, 2014-09-10 07:53:08]

https://chromiumcodereview.appspot.com/550203002/diff/40001/scripts/slave/zip...
File scripts/slave/zip_build.py (right):

https://chromiumcodereview.appspot.com/550203002/diff/40001/scripts/slave/zip...
scripts/slave/zip_build.py:144: def MojomFiles(build_dir, suffixes=None):
On 2014/09/09 19:50:37, Dirk Pranke wrote:
> Nit: there's only one caller of this routine. I'd make suffixes be a required
> parameter. (I'd also rename this to _MojomFiles to make it clearer that
nothing
> outside of this script calls this).

Done.

[qsr, 2014-09-10 07:53:13]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-10 07:53:22]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/550203002/60001

[commit-bot: I haz the power, 2014-09-10 07:54:40]

Committed patchset #4 (id:60001) as 291902

[qsr, 2014-09-10 09:48:43]

A revert of this CL (patchset #4 id:60001) has been created in
https://chromiumcodereview.appspot.com/556203002/ by qsr@chromium.org.

The reason for reverting is: Test are failing on the bots:
http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests/builds/1353....