Add mojo python bindings tests to the waterfalls.

Add mojo python bindings tests to the waterfalls.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291848

[qsr, 2014-08-29 09:21:37]

qsr@chromium.org changed reviewers:
+ phajdan.jr@chromium.org

[Paweł Hajdan Jr., 2014-08-29 09:51:26]

What are you trying to do?

We use the Trusty bots to test Trusty.

It's not really supported on infra yet, and I'd prefer not to use them for
unrelated tests/experiments.

[qsr, 2014-08-29 09:56:49]

On 2014/08/29 09:51:26, Paweł Hajdan Jr. wrote:
> What are you trying to do?
> 
> We use the Trusty bots to test Trusty.
> 
> It's not really supported on infra yet, and I'd prefer not to use them for
> unrelated tests/experiments.

 I'm trying to add a new python test suite to the fyi bots.

[qsr, 2014-09-01 11:40:17]

Updated to also modify the main waterfall. I still changed the fyi bot, because
if the main waterfall change, I guess you want to trusty config to change too.
If that's not the case, just tell me and I will revert my change on the fyi
recipes.

[qsr, 2014-09-01 11:50:47]

Also, how can I test this change? Sending this to trybots doesn't seem to work
at all...

[qsr, 2014-09-02 07:35:09]

gentle ping?

[pgervais, 2014-09-03 18:53:07]

On 2014/09/02 07:35:09, qsr wrote:
> gentle ping?

The only place where such a change should be tested in on the FYI waterfall.
This should definitely not be pushed straight on to the main waterfall.
Pawel: I agree that it's better not to mix experiments. Could you then suggest
another FYI builder on which this could be tested?

[Paweł Hajdan Jr., 2014-09-04 12:43:54]

On 2014/09/03 18:53:07, pgervais wrote:
> On 2014/09/02 07:35:09, qsr wrote:
> > gentle ping?
> 
> The only place where such a change should be tested in on the FYI waterfall.
> This should definitely not be pushed straight on to the main waterfall.
> Pawel: I agree that it's better not to mix experiments. Could you then suggest
> another FYI builder on which this could be tested?

I earlier suggested to Benjamin to _add_ a new FYI builder to test this on.

[qsr, 2014-09-04 12:55:26]

On 2014/09/04 12:43:54, Paweł Hajdan Jr. wrote:
> On 2014/09/03 18:53:07, pgervais wrote:
> > On 2014/09/02 07:35:09, qsr wrote:
> > > gentle ping?
> > 
> > The only place where such a change should be tested in on the FYI waterfall.
> > This should definitely not be pushed straight on to the main waterfall.
> > Pawel: I agree that it's better not to mix experiments. Could you then
suggest
> > another FYI builder on which this could be tested?
> 
> I earlier suggested to Benjamin to _add_ a new FYI builder to test this on.

 Well, you also told me it was not worth the hassle. Now if this is the way to
go forward, can you tell me how I add a new FYI builder.

 I feel all of this seems really heavyweight and complicate while all I want is
to add a new test suite in the waterfall. Shouldn't we have a standard procedure
to do this so that in doesn't take more than a week?

[Dirk Pranke, 2014-09-05 20:05:45]

We're being overly paranoid. I have no concern with adding a new suite of python
tests for mojo directly to the main bots. The whole point of recipes is to make
it easy to revert changes if things go awry, and it's crazy to think we'd want
to stand up a new bot just to add a new test suite.

lgtm.

[Dirk Pranke, 2014-09-06 00:28:28]

dpranke@chromium.org changed reviewers:
+ dpranke@chromium.org

[Dirk Pranke, 2014-09-06 00:28:28]

https://codereview.chromium.org/518663003/diff/40001/scripts/slave/recipe_mod...
File scripts/slave/recipe_modules/chromium/steps.py (right):

https://codereview.chromium.org/518663003/diff/40001/scripts/slave/recipe_mod...
scripts/slave/recipe_modules/chromium/steps.py:504: args = list(cmd_args or [])
This list() call should not be necessary (I don't know why line 520 has it,
either).

[qsr, 2014-09-08 08:43:20]

Thanks.

https://chromiumcodereview.appspot.com/518663003/diff/40001/scripts/slave/rec...
File scripts/slave/recipe_modules/chromium/steps.py (right):

https://chromiumcodereview.appspot.com/518663003/diff/40001/scripts/slave/rec...
scripts/slave/recipe_modules/chromium/steps.py:504: args = list(cmd_args or [])
On 2014/09/06 00:28:28, Dirk Pranke wrote:
> This list() call should not be necessary (I don't know why line 520 has it,
> either).

Done.

[qsr, 2014-09-08 08:43:23]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-08 08:43:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/518663003/60001

[commit-bot: I haz the power, 2014-09-08 08:44:44]

Committed patchset #4 (id:60001) as 291848

[qsr, 2014-09-08 11:56:25]

A revert of this CL (patchset #4 id:60001) has been created in
https://chromiumcodereview.appspot.com/553623003/ by qsr@chromium.org.

The reason for reverting is: Failing on the bots.