Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Unified Diff: chrome/browser/resources/options/clear_browser_data_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/clear_browser_data_overlay.js
diff --git a/chrome/browser/resources/options/clear_browser_data_overlay.js b/chrome/browser/resources/options/clear_browser_data_overlay.js
index 13f186e7ab0d5f3b6b4b8f8f57aaa06d363ba65d..23b9425ef26231c665cfd25bff363047ca32f490 100644
--- a/chrome/browser/resources/options/clear_browser_data_overlay.js
+++ b/chrome/browser/resources/options/clear_browser_data_overlay.js
@@ -3,7 +3,8 @@
// found in the LICENSE file.
cr.define('options', function() {
- var OptionsPage = options.OptionsPage;
+ var Page = cr.ui.pageManager.Page;
+ var PageManager = cr.ui.pageManager.PageManager;
/**
* ClearBrowserDataOverlay class
@@ -11,7 +12,7 @@ cr.define('options', function() {
* @class
*/
function ClearBrowserDataOverlay() {
- OptionsPage.call(this, 'clearBrowserData',
+ Page.call(this, 'clearBrowserData',
loadTimeData.getString('clearBrowserDataOverlayTabTitle'),
'clear-browser-data-overlay');
}
@@ -19,8 +20,8 @@ cr.define('options', function() {
cr.addSingletonGetter(ClearBrowserDataOverlay);
ClearBrowserDataOverlay.prototype = {
- // Inherit ClearBrowserDataOverlay from OptionsPage.
- __proto__: OptionsPage.prototype,
+ // Inherit ClearBrowserDataOverlay from Page.
+ __proto__: Page.prototype,
/**
* Whether deleting history and downloads is allowed.
@@ -51,8 +52,7 @@ cr.define('options', function() {
* Initialize the page.
*/
initializePage: function() {
- // Call base class implementation to starts preference initialization.
- OptionsPage.prototype.initializePage.call(this);
+ Page.prototype.initializePage.call(this);
var f = this.updateStateOfControls_.bind(this);
var types = ['browser.clear_data.browsing_history',
@@ -136,11 +136,11 @@ cr.define('options', function() {
}
$('open-content-settings-from-clear-browsing-data').onclick =
function(event) {
- OptionsPage.navigateToPage('content');
+ PageManager.showPageByName('content');
}
$('open-search-engines-from-clear-browsing-data').onclick =
function(event) {
- OptionsPage.navigateToPage('searchEngines');
+ PageManager.showPageByName('searchEngines');
}
},
@@ -257,9 +257,9 @@ cr.define('options', function() {
};
ClearBrowserDataOverlay.dismiss = function() {
- var topmostVisiblePage = OptionsPage.getTopmostVisiblePage();
+ var topmostVisiblePage = PageManager.getTopmostVisiblePage();
if (topmostVisiblePage && topmostVisiblePage.name == 'clearBrowserData')
- OptionsPage.closeOverlay();
+ PageManager.closeOverlay();
};
// Export

Powered by Google App Engine
This is Rietveld 408576698