chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js - Issue 410293004: Split OptionsPage into Page and PageManager

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Addressed feedback Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/chromeos/change_picture_options.js ('K') | « chrome/browser/resources/options/chromeos/preferred_networks.js ('k') | chrome/browser/resources/options/clear_browser_data_overlay.js » ('j') | chrome/browser/resources/options/factory_reset_overlay.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

diff --git a/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js b/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

index aaf94d928daa8a012333b24ab2d2deaf75d3941f..9d31217bb7c79498268993933737e246858f86be 100644

--- a/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

+++ b/chrome/browser/resources/options/chromeos/third_party_ime_confirm_overlay.js

@@ -3,7 +3,7 @@

// found in the LICENSE file.

cr.define('options', function() {

- /** @const */ var OptionsPage = options.OptionsPage;

+ /** @const */ var PageManager = cr.ui.pageManager.PageManager;

/** @const */ var SettingsDialog = options.SettingsDialog;

/**

@@ -68,7 +68,7 @@ cr.define('options', function() {

var message = loadTimeData.getStringF('thirdPartyImeConfirmMessage',

data.extension);

$('third-party-ime-confirm-text').textContent = message;

- OptionsPage.showPageByName(this.name, false);

+ PageManager.showPageByName(this.name, false);

};