Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4185)

Unified Diff: chrome/browser/resources/options/confirm_dialog.js

Issue 410293004: Split OptionsPage into Page and PageManager (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed feedback Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/confirm_dialog.js
diff --git a/chrome/browser/resources/options/confirm_dialog.js b/chrome/browser/resources/options/confirm_dialog.js
index b7d235eb0271a7723ea239844521b174d848f1cd..ab80f53553b802a9e8a7d2a3916c54c8ed59a0a9 100644
--- a/chrome/browser/resources/options/confirm_dialog.js
+++ b/chrome/browser/resources/options/confirm_dialog.js
@@ -11,9 +11,9 @@ cr.define('options', function() {
* the new value is committed to Chrome. If the user clicks Cancel or leaves
* the settings page, the new value is discarded.
* @constructor
- * @param {string} name See OptionsPage constructor.
- * @param {string} title See OptionsPage constructor.
- * @param {string} pageDivName See OptionsPage constructor.
+ * @param {string} name See Page constructor.
+ * @param {string} title See Page constructor.
+ * @param {string} pageDivName See Page constructor.
* @param {HTMLInputElement} okButton The confirmation button element.
* @param {HTMLInputElement} cancelButton The cancellation button element.
* @param {string} pref The pref that requires confirmation.
@@ -50,7 +50,7 @@ cr.define('options', function() {
return;
if (event.value.value && !this.confirmed_)
- OptionsPage.showPageByName(this.name, false);
+ PageManager.showPageByName(this.name, false);
else
Preferences.getInstance().commitPref(this.pref, this.metric);
},

Powered by Google App Engine
This is Rietveld 408576698