Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: chrome/test/data/webui/link_controller_test.html

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr.isMac fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | third_party/closure_compiler/checker.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/data/webui/link_controller_test.html
diff --git a/chrome/test/data/webui/link_controller_test.html b/chrome/test/data/webui/link_controller_test.html
index d9b8c3600f4d50f3635f1106555af8a3d8809e76..9dd2587161ed3a02854bdc0b76716edcb21d5044 100644
--- a/chrome/test/data/webui/link_controller_test.html
+++ b/chrome/test/data/webui/link_controller_test.html
@@ -24,11 +24,10 @@ var URL2 = '#hash';
var BASE = 'http://www.google.com/';
function setUp() {
-
mockController = new MockController();
mockController.createFunctionMock(chrome.tabs, 'create');
mockController.createFunctionMock(chrome.windows, 'create');
- oldIsMac = cr.isMac;
+ oldIsMac = Object.getOwnPropertyDescriptor(cr, 'isMac');
mockWindow = {
confirm: mockController.createFunctionMock(),
@@ -47,7 +46,7 @@ function setUp() {
function tearDown() {
mockController.verifyMocks();
mockController.reset();
- cr.isMac = oldIsMac;
+ Object.defineProperty(cr, 'isMac', oldIsMac);
}
function testGetWarningMessage() {
@@ -59,7 +58,7 @@ function testGetWarningMessage() {
function openUrlFromEventHelper(event, isMac, expectedKind) {
var lc = new cr.LinkController(localStrings);
- cr.isMac = isMac;
+ Object.defineProperty(cr, 'isMac', {get: function() { return isMac }});
var mock = lc.openUrls = mockController.createFunctionMock();
mock.addExpectation([URL1], expectedKind);
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | third_party/closure_compiler/checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698