Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(554)

Side by Side Diff: chrome/test/data/webui/link_controller_test.html

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: cr.isMac fix Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 <!DOCTYPE html> 1 <!DOCTYPE html>
2 <html> 2 <html>
3 <head> 3 <head>
4 <script src="mock_controller.js"></script> 4 <script src="mock_controller.js"></script>
5 </head> 5 </head>
6 <body> 6 <body>
7 <script> 7 <script>
8 8
9 var mockControl, mockWindow, oldIsMac; 9 var mockControl, mockWindow, oldIsMac;
10 var chrome = chrome || {}; 10 var chrome = chrome || {};
11 chrome.tabs = chrome.tabs || {}; 11 chrome.tabs = chrome.tabs || {};
12 chrome.windows = chrome.windows || {}; 12 chrome.windows = chrome.windows || {};
13 13
14 var MSG = 'MSG'; 14 var MSG = 'MSG';
15 var localStrings = { 15 var localStrings = {
16 getStringF: function(msg, number) { 16 getStringF: function(msg, number) {
17 assertEquals('should_open_all', msg); 17 assertEquals('should_open_all', msg);
18 return MSG + number; 18 return MSG + number;
19 } 19 }
20 }; 20 };
21 21
22 var URL1 = 'http://chromium.org/'; 22 var URL1 = 'http://chromium.org/';
23 var URL2 = '#hash'; 23 var URL2 = '#hash';
24 var BASE = 'http://www.google.com/'; 24 var BASE = 'http://www.google.com/';
25 25
26 function setUp() { 26 function setUp() {
27
28 mockController = new MockController(); 27 mockController = new MockController();
29 mockController.createFunctionMock(chrome.tabs, 'create'); 28 mockController.createFunctionMock(chrome.tabs, 'create');
30 mockController.createFunctionMock(chrome.windows, 'create'); 29 mockController.createFunctionMock(chrome.windows, 'create');
31 oldIsMac = cr.isMac; 30 oldIsMac = Object.getOwnPropertyDescriptor(cr, 'isMac');
32 31
33 mockWindow = { 32 mockWindow = {
34 confirm: mockController.createFunctionMock(), 33 confirm: mockController.createFunctionMock(),
35 location: { 34 location: {
36 get href() { 35 get href() {
37 return BASE; 36 return BASE;
38 }, 37 },
39 set href(url) { 38 set href(url) {
40 assertEquals(URL1, url); 39 assertEquals(URL1, url);
41 } 40 }
42 } 41 }
43 }; 42 };
44 mockWindow.confirm.returnValue = false; 43 mockWindow.confirm.returnValue = false;
45 } 44 }
46 45
47 function tearDown() { 46 function tearDown() {
48 mockController.verifyMocks(); 47 mockController.verifyMocks();
49 mockController.reset(); 48 mockController.reset();
50 cr.isMac = oldIsMac; 49 Object.defineProperty(cr, 'isMac', oldIsMac);
51 } 50 }
52 51
53 function testGetWarningMessage() { 52 function testGetWarningMessage() {
54 var lc = new cr.LinkController(localStrings); 53 var lc = new cr.LinkController(localStrings);
55 var msg = lc.getWarningMessage(10); 54 var msg = lc.getWarningMessage(10);
56 assertEquals(MSG + 10, msg); 55 assertEquals(MSG + 10, msg);
57 } 56 }
58 57
59 function openUrlFromEventHelper(event, isMac, expectedKind) { 58 function openUrlFromEventHelper(event, isMac, expectedKind) {
60 var lc = new cr.LinkController(localStrings); 59 var lc = new cr.LinkController(localStrings);
61 60
62 cr.isMac = isMac; 61 Object.defineProperty(cr, 'isMac', {get: function() { return isMac }});
63 62
64 var mock = lc.openUrls = mockController.createFunctionMock(); 63 var mock = lc.openUrls = mockController.createFunctionMock();
65 mock.addExpectation([URL1], expectedKind); 64 mock.addExpectation([URL1], expectedKind);
66 lc.openUrlFromEvent(URL1, event); 65 lc.openUrlFromEvent(URL1, event);
67 } 66 }
68 67
69 /////////////////////////////////////////////////////////////////////////////// 68 ///////////////////////////////////////////////////////////////////////////////
70 69
71 function testOpenUrlFromEventForegroundTab() { 70 function testOpenUrlFromEventForegroundTab() {
72 var e = { 71 var e = {
(...skipping 211 matching lines...) Expand 10 before | Expand all | Expand 10 after
284 url: [URL1, BASE + URL2], 283 url: [URL1, BASE + URL2],
285 incognito: true 284 incognito: true
286 }); 285 });
287 286
288 lc.openUrls([URL1, URL2], cr.LinkKind.INCOGNITO); 287 lc.openUrls([URL1, URL2], cr.LinkKind.INCOGNITO);
289 } 288 }
290 289
291 </script> 290 </script>
292 </body> 291 </body>
293 </html> 292 </html>
OLDNEW
« no previous file with comments | « chrome/browser/resources/options/browser_options.js ('k') | third_party/closure_compiler/checker.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698