third_party/closure_compiler/checker.py - Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/checker.py

Issue 405743002: Typecheck some of ui/webui/resources/js/ with Closure compiler. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: cr.isMac fix Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/closure_compiler/checker.py

diff --git a/third_party/closure_compiler/checker.py b/third_party/closure_compiler/checker.py

index b0190912da663dbf2f9a83a8adcfc103a94d8909..be7b6f719aebf033ee2a1558a20d0823708d2fbe 100644

--- a/third_party/closure_compiler/checker.py

+++ b/third_party/closure_compiler/checker.py

@@ -88,6 +88,8 @@ class Checker(object):

"--jscomp_error=unknownDefines",

"--jscomp_error=uselessCode",

"--jscomp_error=visibility",

+ # TODO(dbeam): happens when the same file is <include>d multiple times.

+ "--jscomp_off=duplicate",

]

_found_java = False