Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Issue 3014693002: Expose <meta-data> in apk_helper.py (Closed)

Created:
3 years, 2 months ago by agrieve
Modified:
3 years, 2 months ago
Reviewers:
perezju
CC:
catapult-reviews_chromium.org, the real yoland
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Expose <meta-data> in apk_helper.py Need to use this in test runner to inspect incremental install <meta-data>. Bug: chromium:762024 Review-Url: https://chromiumcodereview.appspot.com/3014693002 Committed: https://chromium.googlesource.com/catapult/+/946d4188c628f9d0747c54309b4298ec2dad25f3

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M devil/devil/android/apk_helper.py View 2 chunks +12 lines, -4 lines 2 comments Download
M devil/devil/android/apk_helper_test.py View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (9 generated)
agrieve
On 2017/09/28 00:30:13, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org 🍞
3 years, 2 months ago (2017-09-28 00:30:25 UTC) #3
agrieve
On 2017/09/28 00:30:25, agrieve wrote: > On 2017/09/28 00:30:13, agrieve wrote: > > mailto:agrieve@chromium.org changed ...
3 years, 2 months ago (2017-09-28 01:10:42 UTC) #5
perezju
lgtm w/question Also, probably this needs to be uploaded via gerrit now? https://groups.google.com/a/chromium.org/forum/?utm_medium=email&utm_source=footer#!msg/telemetry-announce/e_04SISOgPw/A_jl7IWmBAAJ https://codereview.chromium.org/3014693002/diff/1/devil/devil/android/apk_helper.py File ...
3 years, 2 months ago (2017-09-28 10:24:38 UTC) #6
agrieve
Will re-upload with gerrif if this fails. Just did a "git cl upload" and this ...
3 years, 2 months ago (2017-09-28 11:54:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3014693002/1
3 years, 2 months ago (2017-09-28 11:54:48 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: Catapult Presubmit on master.tryserver.client.catapult (JOB_FAILED, https://build.chromium.org/p/tryserver.client.catapult/builders/Catapult%20Presubmit/builds/9580)
3 years, 2 months ago (2017-09-28 11:57:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/3014693002/1
3 years, 2 months ago (2017-09-28 11:58:38 UTC) #14
commit-bot: I haz the power
3 years, 2 months ago (2017-09-28 12:26:54 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/catapult/+/946d4188c628f9d0747c54309b4298ec...

Powered by Google App Engine
This is Rietveld 408576698