Expose <meta-data> in apk_helper.py

devil/devil/android/apk_helper.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Module containing utilities for apk packages."""
 
-import itertools
 import re
 
 from devil import base_error
 from devil.android.sdk import aapt
 
 
 _MANIFEST_ATTRIBUTE_RE = re.compile(
     r'\s*A: ([^\(\)= ]*)(?:\([^\(\)= ]*\))?='
     r'(?:"(.*)" \(Raw: .*\)|\(type.*?\)(.*))$')
 _MANIFEST_ELEMENT_RE = re.compile(r'\s*(?:E|N): (\S*) .*$')
@@ skipping 164 matching lines @@
     manifest_info = self._GetManifest()
     try:
       return manifest_info['manifest'][0]['split']
     except KeyError:
       return None
 
   def HasIsolatedProcesses(self):
     """Returns whether any services exist that use isolatedProcess=true."""
     manifest_info = self._GetManifest()
     try:
-      applications = manifest_info['manifest'][0].get('application', [])
-      services = itertools.chain(
-          *(application.get('service', []) for application in applications))
+      application = manifest_info['manifest'][0]['application'][0]
+      services = application['service']

[perezju, 2017/09/28 10:24:38]

what's the reason for this change from all applications to just the first?

[agrieve, 2017/09/28 11:54:34]

Just wanted to make it consistent with how GetAllMetadata() works & to simplify.
It's not valid to have multiple application tags, so there's no reason for the
complexity.

       return any(
           _ParseNumericKey(s, 'android:isolatedProcess') for s in services)
     except KeyError:
       return False
 
+  def GetAllMetadata(self):
+    """Returns a list meta-data tags as (name, value) tuples."""
+    manifest_info = self._GetManifest()
+    try:
+      application = manifest_info['manifest'][0]['application'][0]
+      metadata = application['meta-data']
+      return [(x.get('android:name'), x.get('android:value')) for x in metadata]
+    except KeyError:
+      return []
+
   def _GetManifest(self):
     if not self._manifest:
       self._manifest = _ParseManifestFromApk(self._apk_path)
     return self._manifest
 
   def _ResolveName(self, name):
     name = name.lstrip('.')
     if '.' not in name:
       return '%s.%s' % (self.GetPackageName(), name)
     return name